Tranching refactor

[tsmbland]

Description

I've taken some of the main refactoring/small improvements from #1358 and made this a standalone PR.

• Since Change LCOX to use same optimisation as NPV #1319 we already appraise assets with pre-determined capacities, so can make a number of simplifications to do with that. Firstly, we can set candidate asset capacities to the appropriate capacity, and appraise based on that, rather than passing a max_capacity argument. Also, compare_metric no longer needs to check if capacities are zero, as we can do this beforehand
• Fix capacity_to_activity validation to disallow 0
• calculate_investment_limits_for_candidates (now collect_investment_limits_for_candidates) no longer caps capacities based on the original demand limiting capacity (DLC). Effectively, this means that we can now install more than DLC capacity each year. This helps with Problem treating tranches as separate assets #1383 and simplifies the code/model.
• A couple of example models are affected by the above point.

Fixes # (issue)

Type of change

• Bug fix (non-breaking change to fix an issue)
• New feature (non-breaking change to add functionality)
• Refactoring (non-breaking, non-functional change to improve maintainability)
• Optimization (non-breaking change to speed up the code)
• Breaking change (whatever its nature)
• Documentation (improve or add documentation)

Key checklist

• All tests pass: $ cargo test
• The documentation builds and looks OK: $ cargo doc
• Update release notes for the latest release if this PR adds a new feature or fixes a bug
  present in the previous release

Further checks

• Code is commented, particularly in hard-to-understand areas
• Tests added that prove fix is effective or that feature works

[codecov]

Codecov Report

❌ Patch coverage is 85.71429% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.47%. Comparing base (0177e63) to head (86aa84c).

Files with missing lines	Patch %	Lines
src/simulation/investment.rs	85.18%	8 Missing ⚠️
src/simulation/investment/appraisal.rs	83.33%	0 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1391      +/-   ##
==========================================
- Coverage   89.60%   89.47%   -0.14%     
==========================================
  Files          58       58              
  Lines        8338     8329       -9     
  Branches     8338     8329       -9     
==========================================
- Hits         7471     7452      -19     
- Misses        550      560      +10     
  Partials      317      317              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Copilot]

Pull request overview

This PR refactors the investment “tranching” flow to appraise assets based on their pre-set capacities (rather than passing a separate max_capacity through appraisal/optimisation), tightens capacity_to_activity validation, and updates regression/example outputs to match the new behaviour.

Changes:

• Simplifies appraisal/optimisation by removing the max_capacity parameter and using asset.capacity() directly throughout.
• Updates investment candidate handling and investment-limit collection so annual addition limits are no longer capped by the original demand-limiting capacity (DLC), while still capping per-round capacity by current DLC and remaining addition limits.
• Disallows capacity_to_activity = 0 and propagates the validation change through schema + release notes, updating regression datasets accordingly.

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
tests/data/two_regions/commodity_prices.csv	Updated regression output values for prices under the new investment/appraisal behaviour.
tests/data/two_regions/commodity_flows.csv	Updated regression output values for flows under the new investment/appraisal behaviour.
tests/data/two_regions/asset_capacities.csv	Updated regression output values for installed capacities under the new selection logic.
tests/data/muse1_default/commodity_prices.csv	Updated example/regression output values for prices.
tests/data/muse1_default/commodity_flows.csv	Updated example/regression output values for flows.
tests/data/muse1_default/asset_capacities.csv	Updated example/regression output values for capacities.
src/simulation/investment/appraisal/optimisation.rs	Removes max_capacity plumbing and constrains activities based on asset.capacity().
src/simulation/investment/appraisal/constraints.rs	Updates activity constraints to derive bounds from the asset’s capacity.
src/simulation/investment/appraisal.rs	Removes hypothetical capacity from AppraisalOutput and appraises strictly using the asset’s capacity.
src/simulation/investment.rs	Refactors candidate generation + limit collection and adjusts selection/update logic accordingly.
src/output.rs	Writes appraisal result capacity from the asset’s capacity (since AppraisalOutput.capacity is removed).
src/input/process.rs	Tightens validation to require capacity_to_activity > 0.
src/fixture.rs	Updates fixtures to reflect AppraisalOutput no longer carrying a separate capacity field.
schemas/input/processes.yaml	Updates schema notes to require capacity_to_activity > 0.
docs/release_notes/upcoming.md	Adds release note entry for the capacity_to_activity > 0 validation change.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.