Refactor block material - #2997
Open
TomyLobo wants to merge 3 commits into
Open
Conversation
TomyLobo
commented
Aug 2, 2026
TomyLobo
commented
Collaborator
- Add BlockState.getMaterial()
- Add ShapeType parameter to BlockMaterial.isFullCube
This was referenced Aug 2, 2026
octylFractal
requested changes
Aug 3, 2026
| ] | ||
| } | ||
| ], | ||
| "Why on earth is this even an issue?": [ |
Member
There was a problem hiding this comment.
If someone was implementing BlockMaterial, this can sometimes cause weird issues that I don't recall exactly. But we should have the actual reasoning here, e.g.
Suggested change
| "Why on earth is this even an issue?": [ | |
| "No one should be implementing BlockMaterial": [ |
Collaborator
Author
There was a problem hiding this comment.
I moved that under "Removal of deprecated API for WorldEdit 8" and deprecated the method.
I think that's what we settled on as a long-term goal anyway when we discussed this a few months back.
Member
|
Also alongside octy's review, this currently does not compile, if you'd be able to please fix that too |
TomyLobo
force-pushed
the
refactor-block-material
branch
3 times, most recently
from
August 16, 2026 12:29
b236a17 to
23ba7f5
Compare
TomyLobo
force-pushed
the
refactor-block-material
branch
from
August 16, 2026 13:49
23ba7f5 to
d4805b3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.