Add dog command with random picture feature#347
Open
nekeal wants to merge 1 commit into
Open
Conversation
NMertsch
reviewed
Jun 18, 2026
| def __init__(self) -> None: | ||
| self._session = aiohttp.ClientSession() | ||
|
|
||
| async def close(self) -> None: |
NMertsch
reviewed
Jun 18, 2026
Contributor
There was a problem hiding this comment.
That's a lot of setup and indirection for such simple tests. Can this be simplified?
Contributor
|
Hi @nekeal, sorry for the late response, I hope to be more responsive from now on. Thank you for your work, I'm looking forward to participants' reaction! :) Here is some feedback. My comments on the code are optional as well. Required:
Ideas (optional):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
/doghybrid command that fetches random dog pictures from dog.ceo (https://dog.ceo) API.Changes
Notes
Resolves #341