Skip to content

CI: сборки одной ветки не идут параллельно - #1751

Merged
EvilBeaver merged 1 commit into
EvilBeaver:developfrom
sfaqer:ci/no-concurrent-builds
Sep 26, 2026
Merged

EvilBeaver merged 1 commit into
EvilBeaver:developfrom
sfaqer:ci/no-concurrent-builds

Conversation

@sfaqer

@sfaqer sfaqer commented Sep 26, 2026 •

Copy link
Copy Markdown
Contributor

Сборки develop #15 и #16 одновременно выкладывали night-build, и в папке остались win-x64, win-x86 и osx-x64 от обеих. Когда под маску попадает несколько файлов, сайт отдает 404, поэтому сейчас не скачивается ночная сборка под Windows, и ovm install dev на Windows тоже не работает.

Теперь сборки одной ветки идут по очереди. Папку почистит следующая сборка develop.

🤖 Generated with Claude Code

Сборки develop EvilBeaver#15 и EvilBeaver#16 одновременно выкладывали night-build через
rsync --delete, и в папке остались win-x64, win-x86 и osx-x64 от обеих.
Сайт отдает файл, только если по маске найден один, поэтому эти
дистрибутивы отдают 404, а ovm install dev на Windows не работает.
Теперь сборки одной ветки или PR встают в очередь.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 26, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: ce34c24f-2ca1-438f-adf8-37229daea151

📥 Commits

Reviewing files that changed from the base of the PR and between 270202a and c240d47.

📒 Files selected for processing (1)
  • Jenkinsfile

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.


📝 Walkthrough

Walkthrough

The Jenkins pipeline now calls disableConcurrentBuilds(). Comments describe serialized builds.

Changes

Jenkins build concurrency

Layer / File(s) Summary
Disable concurrent builds
Jenkinsfile
The pipeline calls disableConcurrentBuilds() and adds comments about serialized builds.

Priority: ⬆️ High

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Suggested reviewers: evilbeaver

Merge Risk: ⚪ Minimal · up to c240d

In the Multibranch setup identified by the Jenkinsfile, same-branch builds queue while separate branch builds can run concurrently. No material merge risk is evident.

Architecture Summary

Architecture risk: 🔵 Low · up to c240d

The change affects 1 system.

Changed systems: Jenkinsfile

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — Jenkinsfile (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in Jenkinsfile: The pipeline adds comments describing serialized same-branch builds and configures disableConcurrentBuilds() to prevent concurrent pipeline runs.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: CI builds for the same branch no longer run in parallel. It is concise and specific.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@EvilBeaver
EvilBeaver merged commit 8217567 into EvilBeaver:develop Sep 26, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants