Skip to content

[Test only - do not merge] Pin wallet fix for iOS ad-hoc testing - #103360

Closed
francoisl wants to merge 1 commit into
mainfrom
francois-test-ios-wallet-cancel-retry
Closed

[Test only - do not merge] Pin wallet fix for iOS ad-hoc testing#103360
francoisl wants to merge 1 commit into
mainfrom
francois-test-ios-wallet-cancel-retry

Conversation

@francoisl

@francoisl francoisl commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

Test only. Do not merge this PR. Close it after ad-hoc testing. The production dependency update will be a separate PR using the published wallet release.

Pin @expensify/react-native-wallet to commit 12e1a6827ac0cbcd1efaa06b6e69368f95132e78 from the wallet fix PR. This lets us test cancellation and retry of the Download Wallet prompt on a physical iPhone before merging the library fix.

This PR updates the npm dependency and lockfile, aligns the standalone iOS pod lockfile, and adds a temporary hybrid-build setup step. The setup step applies only the wallet version/checksum changes to Mobile-Expensify/iOS/Podfile.lock before CocoaPods cache lookup. It also runs when node dependencies come from cache. The Mobile-Expensify submodule commit is unchanged.

The wallet commit reports version 0.1.38. App currently uses 0.1.22, so this test build also includes the intervening wallet changes.

Fixed Issues

$ #102403
PROPOSAL: #102403 (comment)

This is a temporary test build for the linked issue, not the production fix.

Tests

Local checks completed:

  • npm pack successfully prepares the wallet Git dependency, including its generated JavaScript and TypeScript declarations.
  • STANDALONE_NEW_DOT=true npm ci succeeds with Node 26.5.0 and npm 11.17.0.
  • The installed WalletManager.swift matches the pinned wallet commit exactly.
  • npm run typecheck passes.
  • npm run lint-changed passes with no lintable files changed.
  • npm run spell-changed and formatting checks pass.
  • The actual hybrid setup step applies cleanly, is idempotent, changes only the wallet version/checksum, and passes ShellCheck.
  • CocoaPods serialization confirms the wallet checksum used in both native lockfiles.

The ad-hoc build and physical-device tests are pending. Run these steps:

  1. Open the Build and deploy apps for testing workflow.
  2. Enter this PR's URL in APP_PULL_REQUEST_URL.
  3. Enable IOS.
  4. Disable WEB and ANDROID.
  5. Enable FORCE_NATIVE_BUILD.
  6. Complete the workflow's required code-review confirmation.
  7. Start the workflow.
  8. Install the resulting ad-hoc IPA on a registered physical iPhone.
  9. Sign in to an account with an assigned virtual card.
  10. Remove the Wallet app from the iPhone.
  11. Open Account > Wallet and select the virtual card.
  12. Tap Add to Apple Wallet.
  13. Cancel the Download Wallet prompt.
  14. Confirm the button stops loading.
  15. Tap Add to Apple Wallet again.
  16. Confirm the Download Wallet prompt reappears.
  17. Cancel the prompt again.
  18. Confirm the button stops loading.
  19. Reinstall Wallet.
  20. Add the virtual card to Apple Wallet.
  21. Confirm normal provisioning completes successfully.
  • Verify that no errors appear in the JS console

Offline tests

Pending physical-device verification:

  1. Open the virtual card while online, with Wallet removed from the iPhone.
  2. Enable Airplane Mode.
  3. Tap Add to Apple Wallet.
  4. Cancel any displayed prompt.
  5. Confirm cancellation or an unavailable-service error returns the button from loading.
  6. Disable Airplane Mode.
  7. Retry Add to Apple Wallet.
  8. Confirm the Download Wallet prompt reappears.

QA Steps

Use the planned physical-device steps under Tests with this PR's ad-hoc IPA. QA is pending. This PR must remain a draft and must not be merged or deployed to staging/production.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

N/A. This is an iOS-only ad-hoc test PR.

Android: mWeb Chrome

N/A. This is an iOS-only ad-hoc test PR.

iOS: Native

Pending ad-hoc build and physical-device verification.

iOS: mWeb Safari

N/A. The affected flow is native iOS payment-card provisioning.

MacOS: Chrome / Safari

N/A. The affected flow is native iOS payment-card provisioning.

@francoisl
test: pin wallet cancellation fix for ad-hoc iOS testing
fd5a6a9 
Pin the upstream wallet commit and align the standalone and hybrid pod
locks. Apply the hybrid lock fixture during setup, including dependency
cache hits, so the ad-hoc build compiles the updated native library.

This branch is for testing only and must not be merged.
@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

🚧 francoisl has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #103360.

Android 🤖 iOS 🍎
⏩ SKIPPED ⏩ https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-fd5a6a9-427b2bc-ca5523f5a6295d0399564ba3adb8b8e6fda5a472/index.html
The build for Android was skipped iOS
Web 🕸️
⏩ SKIPPED ⏩
The build for Web was skipped

👀 View the workflow run that generated this build 👀

@francoisl

francoisl commented Oct 7, 2026

Copy link
Copy Markdown
Contributor Author

Asked for a retest using this build. Tracking: https://expensify.slack.com/archives/C09V78U42D8/p1791396126078879

@francoisl francoisl mentioned this pull request Oct 8, 2026
Merged
@francoisl francoisl closed this Oct 12, 2026
@francoisl
francoisl deleted the francois-test-ios-wallet-cancel-retry branch October 12, 2026 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@francoisl francoisl

Labels

Ready To Build

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@francoisl