Repository navigation
test(cli): report the runner error in the issue 208 pipe-writer test - #290
Merged
Merged
Conversation
The test has failed intermittently on hosted macOS runners (x86 run 41540831671, ARM run 41554072594) at a bare assert!(result.is_ok()), which hides the message. It passes 12/12 locally on Linux under load. Print the runner's error so the next macOS failure names its cause.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 59 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. CodeRabbit Verify
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue_208_runner_finishes_after_closing_descendant_pipe_writershas failed intermittently on hosted macOS runners: x86 41540831671 and ARM 41554072594. Both failed atassert!(result.is_ok())(test_mode.rs:810) and passed on rerun.The shell exits with code 0, so the likely error is the 2 s output-drain deadline in
run_test_commands_inner, where a backgroundedsleep 20holds the pipes. That is unproven: the bare assertion hides the message. Locally on Linux the test passed 12/12 under load average ~190.This change only makes the failure print the runner's error, so the next macOS failure names its cause. It is not a fix.