Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Local environment flag evaluations were silently missing from analytics because the returned flags did not receive the configured analytics processor. Forward the same options as the local identity path so cached evaluations are counted and missing flags retain the configured fallback handler.
Changes
Contributes to #304.
Restore analytics and default-handler behavior for locally evaluated environment flags. Regression coverage includes remote/local parity, cached evaluations, analytics disabled, and the configured fallback.
Two development prerequisites surfaced while running the required hooks: the current context schema references
evaluation-result.jsonafter the result-generation step has deleted it, so context generation now downloads its referenced schema and cleans both inputs afterward. The generated optional context types are included. Also route the test suite's default global fetch through its existing fixture; previously several tests issued real network requests and intermittently timed out. No hooks were skipped.How did you test this code?
npm test: 459 passes, with coverage.npm run test:esm-build: TypeScript builds pass, 449 tests pass / 10 intentionally skipped by ESM configuration.git diff --checkpasses.Graphify local AST query
getEnvironmentFlagsFromDocument analyticsProcessor Flags fromEvaluationResultand method explanation traced the factory/cache path; source inspection confirmed the missing options. Additional package and test-setup graph queries covered the hook prerequisites. Graph artifacts are excluded.AI assistance:
openai/gpt-oss-120bthrough Nodus inference generated the SDK options fix. Codex authored tests, repaired the code-generation prerequisite and network fixture, reviewed changes and ran checks. PR text and follow-up may be AI-assisted.Review effort: 2/5.