infra(OTel): Wire OTEL_EXPORTER_ENDPOINT in ECS task defs#7251
Merged
Conversation
In this PR, we add OTEL_EXPORTER_ENDPOINT pointing at the ADOT collector's CloudMap hostname to the admin-api, sdk-api, and task-processor task definitions for both staging and production, so the services can emit OTLP logs and traces to the shared collector (see Flagsmith/pulumi#182). beep boop
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
There was a problem hiding this comment.
Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit at claude.ai/admin-settings/claude-code.
Once credits are available, reopen this pull request to trigger a review.
emyller
approved these changes
Apr 15, 2026
Member
Author
|
This is blocked on state drift in staging Pulumi the "verify the CloudMap hostname resolves from an API task in staging" part worked but the TCP port isn't accessible yet due to a secgrp mismatch. |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs/if required so people know about the feature.Changes
Contributes to Flagsmith/pulumi#170
In this PR, we add
OTEL_EXPORTER_ENDPOINTpointing at the ADOT collector's CloudMap hostname to the admin-api, sdk-api, and task-processor task definitions for both staging and production, so the services can emit OTLP logs and traces to the shared collector once Flagsmith/pulumi#182 is deployed. The migration task def is intentionally left alone — it's a one-shot and doesn't emit events.The endpoint is identical for staging and production because CloudMap is per-VPC and the
metrics.localnamespace resolvesadot-collectorinside each environment's VPC.Depends on Flagsmith/pulumi#182.
How did you test this code?