feat: lock CR UI once any reviewer has approved (#7056)#7255
feat: lock CR UI once any reviewer has approved (#7056)#7255gagantrivedi merged 2 commits intomainfrom
Conversation
Hide the Edit button, show an InfoMessage banner, and make the assigned-users/groups sections read-only when the CR has at least one approval. Depends on flagsmith-workflows#111 for the backend guard.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
github-actions
bot
added
the
front-end
Picks up the ApprovedChangeRequestLockMixin guard from flagsmith-workflows#111.
github-actions
bot
added
api
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7255 +/- ##
==========================================
+ Coverage 98.29% 98.36% +0.06%
==========================================
Files 1351 1351
Lines 50779 50779
==========================================
+ Hits 49912 49947 +35
+ Misses 867 832 -35 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gagantrivedi
requested review from
emyller and
kyle-ssg
and removed request for
a team
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit at claude.ai/admin-settings/claude-code.
Once credits are available, reopen this pull request to trigger a review.
github-actions
bot
added
feature
Docker builds report
|
Playwright Test Results (oss - depot-ubuntu-latest-16)
Details
Playwright Test Results (oss - depot-ubuntu-latest-arm-16)
Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)
Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-16)
Details
|
Visual Regression16 screenshots compared. See report for details. |
Zaimwa9
left a comment
Zaimwa9
left a comment
There was a problem hiding this comment.
Approving with a minor NIT leaving it on you. Anyways this file is bloated and will need to be broken down at some point
I can't see your nit comment? |
2 participants
docs/if required so people know about the feature.Changes
Contributes to #7056
Once any reviewer has approved a Change Request, the UI locks down:
All changes are in
ChangeRequestPageInnerwhich is shared by both env-scoped and project-scoped CR detail pages.How did you test this code?
Ran npm run typecheck — zero new TypeScript errors (all pre-existing). Manual browser testing confirms that edit is no longer available once a change request is approved and the note is showing up correctly