Skip to content

test: fix random failing e2e tests#2127

Merged
cstns merged 16 commits into
mainfrom
test_attempt_to_fix_failing_tests
May 26, 2026
Merged

test: fix random failing e2e tests#2127
cstns merged 16 commits into
mainfrom
test_attempt_to_fix_failing_tests

Conversation

@ppawlowski
Copy link
Copy Markdown
Contributor

@ppawlowski ppawlowski commented May 20, 2026

Description

This pull request attempts to stabilise failing E2E tests.

Note: Changes introduced in this pull request were created with strong AI support. Caution is required during the review.

Related Issue(s)

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@ppawlowski ppawlowski changed the title test: attempt to fix failing cypress tests test: fix random failing cypress tests May 20, 2026
@ppawlowski ppawlowski marked this pull request as ready for review May 20, 2026 15:01
@ppawlowski ppawlowski requested a review from cstns May 20, 2026 15:01
@ppawlowski ppawlowski changed the title test: fix random failing cypress tests test: fix random failing e2e tests May 20, 2026
Copy link
Copy Markdown
Contributor

@cstns cstns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a very good attempt, i had a feeling it would do the trick because that was my line of thinking on why tests fail. Unfortunately on subsequent test runs the tests keep failing.

i ran them three times locally. The first pass was successful, the second time the config-nodes/base.spec.js test failed and the third more failed:

tests.log

Comment thread cypress/tests/widgets/form.spec.js
@ppawlowski
Copy link
Copy Markdown
Contributor Author

ppawlowski commented May 21, 2026

@cstns I've 404 on https://github.com/user-attachments/files/28065011/tests.log . Could you re-upload, please?

@ppawlowski
Copy link
Copy Markdown
Contributor Author

@cstns I've 404 on https://github.com/user-attachments/files/28065011/tests.log . Could you re-upload, please?

After a couple more attempts to download it, I finally have it 😕

@ppawlowski
Copy link
Copy Markdown
Contributor Author

@cstns the E2E tests pipeline completed successfully 10 times in a row. I think it is safe to review again.

@ppawlowski ppawlowski requested a review from cstns May 21, 2026 21:01
@ppawlowski
Copy link
Copy Markdown
Contributor Author

@cstns I've made some adjustments to run tests reliably on a local environment without breaking the CI pipeline. I've managed to run tests locally without issues 5 times in a row and 10 more times in the CI pipeline.
Please review.

@cstns
Copy link
Copy Markdown
Contributor

cstns commented May 26, 2026

the cypress/tests/config-nodes/base.spec.js e2e test is always failing on my end and it doesn't seem to be related to the changes you made. trying to figure out what's happening with the fixture or my setup before green lighting this

…nintended cross-widget selector matches during e2e tests.
Copy link
Copy Markdown
Contributor

@cstns cstns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this!

I also pushed a small fix for the form spec test which was constantly failing locally

@cstns
Copy link
Copy Markdown
Contributor

cstns commented May 26, 2026

why are the e2e tests not running against this PR after my latest push?

@ppawlowski
Copy link
Copy Markdown
Contributor Author

why are the e2e tests not running against this PR after my latest push?

I've pushed an irrelevant change to force them to run again.

@cstns
Copy link
Copy Markdown
Contributor

cstns commented May 26, 2026

ok, that's strange. I now see what actions ran but previously I didn't.. I'll blame it on GH's bad day

@cstns cstns merged commit 132a11a into main May 26, 2026
5 checks passed
@cstns cstns deleted the test_attempt_to_fix_failing_tests branch May 26, 2026 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants