Comments: drop audit tags (macOS); delete unused entitlements.browser.plist; CI guard - #55
Merged
Merged
Conversation
….plist; CI guard The macOS plugin and host carried the same unresolvable references #53 removed from Windows/Dart: audit ids (C1-C3, H1-H9, R2, "audit P3"), the visibility/resize audit's fix ids (F-1..F-6, C-3), the agent-control plan's phase ids (CEF-1, CEF-2a/b, P2-step1/2), the persistent-profile contract's section numbers (F.3-F.5, A.4, H.6), a "#138 consolidation" and pointers to work_canvas's specs/cef-passkey/PLAN.md, another repo. Each tag is replaced by its reason in words, or dropped where the sentence already said it. The "[cef] C2 respawn ephemeral host failed" log line loses its tag too. entitlements.browser.plist was an auth-spike leftover: nothing signs with it. The build (CMakeLists.txt) and tool/bundle_cef_host.sh sign cef_host and every helper with the same file, entitlements.release.plist for a real identity. Its comment now says so, and why the passkey keychain group is not in it. The CMakeLists comment claiming both sets keep allow-unsigned-executable-memory and disable-library-validation is corrected (only the dev set does). Deleting the file changes the cef_host input hash. tool/check_comment_tags.sh fails on the unambiguous shapes (LAW n, the all-caps slice word, the spike log file name, file.ext:line citations, a comment that opens with a letter+digits label, a parenthesised label) outside docs/history/ and CHANGELOGs. CI's analyze-test job runs it. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The macOS half of the pass #53 did for Windows, Dart and tooling, plus a CI check so the tags don't come back.
Comments. The macOS plugin and host still carried references a reader can't resolve: audit ids (C1–C3, H1–H9, R2, "audit P3"), the visibility/resize audit's fix ids (F-1…F-6, C-3), the agent-control plan's phase ids (CEF-1, CEF-2a/b, P2-step1/2), the persistent-profile contract's section numbers (F.3–F.5, A.4, H.6), a "#138 consolidation", and pointers to
specs/cef-passkey/PLAN.mdin work_canvas, another repo. Before this PR, 173 lines carried one of these tags (141 of them matched by the sweep's finder regex). Now none do. Each tag is replaced by its reason in words, or dropped where the sentence already gave it. A repeated idea is restated briefly each time; for example, "(H3)" becomes "the plugin's maps are main-thread confined". Two leftovers outside the package are fixed too:profile_probe.dartnamed a spike-era output directory the code no longer uses, andchannel_probe_shared.dartcited the "#138 consolidation". The one non-comment change is the log line[cef] C2 respawn ephemeral host failed→[cef] ephemeral respawn failed. Nothing in the repo matches on it.The Mach message audit trailer in
SurfacePort.swift(auditTrailer,mach_msg_audit_trailer_t) is a real kernel term and is left alone.entitlements.browser.plistdeleted. It was left over from the passkey spike, and nothing signs with it. The build's post-build codesign (CMakeLists.txt) andtool/bundle_cef_host.shsign cef_host and every helper with one file:entitlements.release.plistforCEF_HOST_ADHOC=OFFor a real identity (which is whatpublish-cef-host.shbuilds), otherwiseentitlements.plist. Nothing applies a separate browser-only file. The note inentitlements.release.plistclaimed otherwise. It now says the file is shared by the host and its helpers, which is why it carries no keychain-access-groups: a helper with that group and no provisioning profile is AMFI-killed. It also says an app that wants Touch ID passkeys has to re-sign its bundled cef_host itself. TheCMakeLists.txtcomment beside the entitlements selection said both sets keep allow-unsigned-executable-memory and disable-library-validation. Only the dev set does, so that comment is corrected too. The whole repo was grepped first, and the release plist's note was the only reference to the file.This changes the cef_host prebuilt input hash (
native/cef_host/**is hashed). A republish is already pending; nothing is published here.CI guard.
tool/check_comment_tags.shgreps tracked files, skippingdocs/history/, CHANGELOGs and binary files, for the shapes that are never anything else:LAW <n>, the all-caps word SLICE,SPIKES.md<name>.(mm|cc|cpp|h|swift|dart):<digits>//,///,#or*) that opens with[A-Z]\d{1,2}(/[A-Z]\d{1,2})?:\((audit )?[A-Z]\d{1,2}\)It prints
file:line: textper hit and exits 1. It uses only git and POSIX ERE, runs under macOS/bin/bash3.2 and on Ubuntu, and has no allowlist. It runs as the first step of the analyze-test job, and CONTRIBUTING.md mentions it in one sentence. Onmainit reports 56 hits, all real tags, which this PR fixes. On the commit before #53 it reports 239.Verification
.mm/.hfiles were also cross-checked with GNUcpp -fpreprocessed.FLUTTER_CEF_STOCK_FRAMEWORK=1 native/build_cef_host.shbuilds cef_host.app.packages/flutter_cef_macos/test/run_*.sh) pass.flutter analyzeis clean, andflutter testpasses (280 tests).bash -npasses on the new and touched scripts.// H2: xtoResizeWatchdogPolicy.swiftmakes the guard fail, on macOS bash 3.2 and on Ubuntu 24.04./// C1/H2:,(audit P3),LAW 4, SLICE,SPIKES.md,main.mm:123,# F9:and* X12:are each caught too, and(x64),(F1-F12),C0,V8/,slice(1)are not. After removal, the guard is clean again.🤖 Generated with Claude Code