fix(web): align provider dialogs and add workspace composition coverage - #2922
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
xldialog maximum width to 800px.DialogBodyown scrolling instead of nesting another scroll container.Type and Areas
Type: Bug fix / UI/UX / test
Areas: Web UI, design tokens, Design Lab, shared UI documentation, generated data-migrator styles.
Motivation / Impact
Provider dialogs previously used a narrower layout and nested scrolling that competed with the shared dialog's spacing and footer behavior.
The updated composition provides consistent width, scrolling, and floating actions. Workspace creation retains its small dialog, attached footer, existing control sizes, and internal field dividers.
Verification
Recorded validation for this patch:
pnpm run design-system:check— passed.pnpm run check:web— passed, including theme audits and TypeScript checks.Workspace tests cover disabled controls during creation, form preservation after failure, peer-aware picker delegation, and remote-style path preservation.
Checks were not rerun while drafting this description. Full provider scrolling, keyboard, theme, and narrow-window visual verification remains pending.
Reviewer Notes
xlwidth change affects all consumers of that shared dialog size.Checklist