fix(mobile): align native onboarding, GitHub login and remote session flows - #2956
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mobile controllers now offer notification permission during first-launch onboarding, preserve remote-session send authority when the visible session list is filtered, and provide consistent native account and conversation controls.
Type and Areas
Type: Bug fixes / UI/UX / tests
Areas: iOS, Android, HarmonyOS, mobile shared core, MiniApp market authorization page, brand assets
Motivation / Impact
Users can send from a correctly opened remote session without silently failing because the sidebar list differs. Notification permission is offered before the first task instead of appearing during task execution. iOS login no longer requires a second blue-link tap, and the sidebar's New Chat button creates conversations instead of reconnecting. The authorization completion page avoids the missing Chinese glyphs reproduced in iOS Simulator Safari.
Verification
After rebasing onto upstream/main:
Testing/run-pure-swift-tests.sh: passed../gradlew :app:assembleDebug: passed../gradlew :core-feature:assembleOpenBitFunMobileCoreDebugXCFramework: passed.xcodebuild -project OpenBitFun.xcodeproj -scheme OpenBitFun -destination 'platform=iOS Simulator,name=iPhone 17 Pro' build: passed after regenerating the shared framework for upstream's newlastSentMessagefield.Focused checks passed during this work:
./gradlew :core-feature:jvmTest :core-transport:jvmTest.pnpm run mobile:architecture;node --test scripts/generate-brand-assets.test.mjs(12 tests).pnpm run theme:color-audit:native-mobile.pnpm run theme:color-audit:allremains blocked by the existing missing@xterm/headless/lib-headless/xterm-headless.mjsdependency during startup-appearance generation.Reviewer Notes
harness_profiles_v1; old payloads keep the legacy path. Display metadata is separate from account authority and preserves credentials on refresh failures.Checklist