feat(core): move default settings to seperate conf#3745
Open
h3o66 wants to merge 1 commit intoGameServerManagers:developfrom
Open
feat(core): move default settings to seperate conf#3745h3o66 wants to merge 1 commit intoGameServerManagers:developfrom
h3o66 wants to merge 1 commit intoGameServerManagers:developfrom
Conversation
3 tasks
b24f9ae to
4bfd09b
Compare
aa1e704 to
3960d3e
Compare
13 tasks
Member
|
I am happy with the idea. I just need to do testing 👍🏻 |
Member
Author
looks like it needs at first a rebase before testing to match the develop branch |
89e7f60 to
dacc33e
Compare
Member
Author
|
Rebased. |
c5c0259 to
0df6cfb
Compare
Member
Author
|
Rebased this again to the latest develop branch and added the 2 new added servers to the PR. |
0df6cfb to
88bea7a
Compare
f02e53d to
2257be4
Compare
891ed8f to
ca184e3
Compare
7a72c04 to
f28a4e5
Compare
8d80501 to
fdb8625
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Move the notification part to a seperate config and prevent users from making changes there.
Fixes #3741
Type of change
Checklist
PR will not be merged until all steps are complete.
developbranch as its base.Documentation
If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.
Thank you for your Pull Request!