fix: Prevent ThingTemplate::parseModuleName null dereference crash - #543
Open
seer-by-sentry[bot] wants to merge 1 commit into
Open
fix: Prevent ThingTemplate::parseModuleName null dereference crash#543seer-by-sentry[bot] wants to merge 1 commit into
seer-by-sentry[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses CLIENT-317 by adding a null-check after the call to
TheModuleFactory->newModuleDataFromINI()withinThingTemplate::parseModuleName.Previously, if
newModuleDataFromINI()returned anullptr(indicating an unknown module name referenced in an INI file), the subsequent dereference of this null pointer (data->isAiModuleData()) would lead to a fatalEXCEPTION_ACCESS_VIOLATION_READcrash.The fix introduces a check for
nullptrand, if detected, triggers aDEBUG_CRASHwith relevant context and throwsINI_INVALID_DATA, allowing for a graceful failure during INI parsing instead of a hard crash. This change was applied to bothGenerals/Code/GameEngine/Source/Common/Thing/ThingTemplate.cppandGeneralsMD/Code/GameEngine/Source/Common/Thing/ThingTemplate.cpp.This issue was previously identified and fixes were attempted in PRs #353 and #433, but these were never merged.
Fixes CLIENT-317