Add python and go extension to publish workflow - #144
Merged
Conversation
Add python and go extension to publish workflow
Closed
felickz
added a commit
that referenced
this pull request
Jul 6, 2026
- pr-version-bump-check.sh: only check ext/ext-library-sources for csharp/java, matching publish.yml's actual matrix. go/ext and python/ext exist but aren't published by publish.yml (see #144), so telling contributors a version bump would ship them was misleading. - check-codeql-release.sh: replace broken `../blob/main/...` relative links in the generated issue body with full https://github.com/... URLs (derived from $GITHUB_REPOSITORY), since GitHub issue markdown resolves relative links against the issue's own path, not the repo root. - ci.yml: rename the advisory job from "Check pack version was bumped" to "Warn if pack version bump is missing" so the Actions UI doesn't imply the version was actually bumped when this job runs/passes. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
felickz
added a commit
that referenced
this pull request
Jul 10, 2026
.release.yml's version was bumped to 0.2.3 directly (not via a pack version bump), and java/lib was independently bumped to 0.2.3 by PR #155's hotfix. This closes the gap by bringing every other pack's own qlpack.yml version in line, so merging this triggers the real batch publish of everything to 0.2.3 (java/lib is already live and will be a no-op). Also bumps go/ext and python/ext/qlpack.yml for consistency with .release.yml's 'CodeQL Pack Versions' location pattern, even though those two packs aren't wired into publish.yml's matrix yet (tracked by open PR #144). Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Expands the publish workflow’s extensions job matrix so that CodeQL extension packs for additional languages are published alongside the existing ones.
Changes:
- Add
pythonandgoto theextensionsjob language matrix in.github/workflows/publish.yml.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/publish.yml | Extends the extensions job matrix to include python and go so their extension packs can be published. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Low
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
felickz
requested changes
Jul 27, 2026
Contributor
There was a problem hiding this comment.
Verified this against main
What I checked:
python/ext/qlpack.ymlandgo/ext/qlpack.ymlalready exist onmain(added back in the 0.2.0 era) and have been kept version-bumped in lockstep withcsharp/javathrough every release since (currently0.7.0). They're already part of the release process — they've just never actually been published, because thisextensionsjob matrix excludes them.- Confirmed on GHCR:
codeql-java-extensionsis live at0.7.0, butcodeql-python-extensionsandcodeql-go-extensionsboth 404 — i.e. this gap is real and exactly matches what this PR fixes. - Locally ran
codeql pack install+codeql pack create(CLI 2.25.6, same as CI) againstpython/extandgo/ext— both succeed (exit 0, "Library pack creation complete"), with only the same pre-existingaddsTo.pack ... is not an extension targetwarning that also fires today for the already-publishedcsharp/extandjava/ext. So that warning is a repo-wide, pre-existing cosmetic issue, not something this change introduces or something blocking a first publish. - This job has no csharp/java-specific logic outside the matrix (
${{ matrix.language }}/extis used throughout, and the "package doesn't exist yet" 404 case is already handled via|| true), so a first-time publish for python/go will behave the same way csharp/java's did originally.
*Two small changes
.github/workflows/ci.ymlhas a siblingextensionsjob (matrix at line ~168) that's also hardcoded to["csharp", "java"]and validatespack install/pack createon every PR touching<lang>/ext/**. It's not touched by this PR, sopython/ext/go/extchanges still won't get CI coverage even after this merges. Worth adding python/go there too for parity:- language: [ 'csharp', 'java' ] + language: [ 'csharp', 'java', 'python', 'go' ]CONTRIBUTING.mdcurrently has a line that explicitly calls out this PR by number ("ext/ext-library-sourcesonly run forcsharp/javatoday, see #144") — that caveat should be removed/updated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Updated the supported languages for extensions in the contributing guidelines.
felickz
approved these changes
Jul 27, 2026
👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add python and go extension to publish workflow