Skip to content

[WIP] Fix failing GitHub Actions job Validate test results #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
felickz merged 3 commits into from
Jul 28, 2026
Merged

[WIP] Fix failing GitHub Actions job Validate test results #192

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
69b18fb
Initial plan
Copilot Jul 28, 2026
59e62c1
Fix validate-test-results and configs CI job failures
Copilot Jul 28, 2026
a0610f3
ci: add packages: read permission to configs job for GHCR rate limiting
Copilot Jul 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ jobs:
do
jq --raw-output '"PASS \(map(select(.pass == true)) | length)/\(length)"' "$json_report"
done
FAILING_TESTS=$(jq --raw-output '.[] | select(.pass == false)' "${test_reports[@]}")
FAILING_TESTS=$(jq --slurp --raw-output '.[][] | select(.pass == false)' "${test_reports[@]}")
if [[ ! -z "$FAILING_TESTS" ]]; then
echo "ERROR: The following tests failed:"
echo $FAILING_TESTS | jq .
Expand Down Expand Up @@ -229,6 +229,7 @@ jobs:
needs: compile-and-test
permissions:
contents: read
packages: read # required by codeql pack install (GHCR rate limiting)
pull-requests: read # required by pr-configs.sh (gh pr view)

steps:
Expand All @@ -245,6 +246,17 @@ jobs:
if: steps.changes.outputs.src == 'true' || github.event_name == 'workflow_dispatch'
uses: ./.github/actions/install-codeql

- name: Install Packs
if: steps.changes.outputs.src == 'true' || github.event_name == 'workflow_dispatch'
env:
GITHUB_TOKEN: ${{ github.token }}
run: |
Comment on lines +249 to +253

Copilot AI Jul 28, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added packages: read to the configs job permissions in 6d4bdab. The GHCR package is public so authentication is not required, but the permission helps avoid rate limiting during codeql pack install.

for lang in cpp csharp go java javascript python ruby; do
if [[ -d "${lang}/src" ]]; then
codeql pack install "${lang}/src"
fi
done

- name: "Check Configurations"
if: steps.changes.outputs.src == 'true' || github.event_name == 'workflow_dispatch'
env:
Expand Down