Repository navigation
Update Jetty to 12.1.15 and 12.0.41, and update minor/patch dependencies - #562
Merged
Merged
Conversation
- Update Jetty to 12.1.15 and 12.0.41 - Bump actions/setup-java from 6.1.0 to 6.2.0 (#560) - Bump com.google.guava:guava and guava-testlib from 33.7.2-jre to 33.8.0-jre (#561) - Bump com.google.errorprone:error_prone_annotations from 2.51.0 to 2.52.0 (#561) - Bump org.jsoup:jsoup from 1.23.2 to 1.24.1 (#561) - Bump joda-time:joda-time from 2.15.0 to 2.15.1 (#561)
luchampe
approved these changes
Nov 11, 2026
Collaborator
|
@ludoch I ran Claude over this and it says there is one thing this PR missed, is the 12.1.15 renamed it to So I think we should drop the |
Collaborator
Author
|
Thank you @lachlan-roberts! Addressed in follow-up PR #563. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unifies Jetty version upgrades with #560 and #561, and adapts the SDK to Jetty 12.1.15's restructured directory layout.
Upgrades Summary
jetty12.version:12.0.40->12.0.41jetty121.version:12.1.14->12.1.15actions/setup-javafrom6.1.0to6.2.0in.github/workflows/maven.ymlcom.google.guava:guavafrom33.7.2-jreto33.8.0-jrecom.google.guava:guava-testlibfrom33.7.2-jreto33.8.0-jrecom.google.errorprone:error_prone_annotationsfrom2.51.0to2.52.0org.jsoup:jsoupfrom1.23.2to1.24.1joda-time:joda-timefrom2.15.0to2.15.1Jetty 12.1.15 Directory & File Structure Changes
Jetty 12.1.15 reorganized
${jetty.home}/lib/from a flat layout with prefixed subdirectory names into structured, environment-isolated directories:lib/lib/(unchanged)lib// flatlib/support/jetty-ee8-*.jar)lib/lib/ee8/lib/ee8-annotations/,lib/ee8-apache-jsp/,lib/ee8-glassfish-jstl/lib/ee8/support/jetty-servlet-api-4.0.9.jar)lib/lib/ee8/jetty-ee11-*.jar)lib/lib/ee11/lib/ee11-annotations/,lib/ee11-apache-jsp/,lib/ee11-glassfish-jstl/lib/ee11/support/jakarta.servlet-api-6.1.0.jar)lib/lib/ee11/support/lib/ee8-apache-jsp/,lib/ee11-apache-jsp/lib/ee8-apache-jsp/,lib/ee11-apache-jsp/(preserved in assembly)Migration & SDK Adaptation
To ensure backward compatibility while supporting the new layout in
Jetty121EE8Sdk.javaandJetty121EE11Sdk.java:Graceful Subdirectory Discovery (
getJetty121Jars):IllegalArgumentExceptionon missing subdirectories withCollections.emptyList().ee8-annotations,ee11-glassfish-jstl) on older releases while seamlessly loadingee8,ee8/support,ee11,ee11/support, andsupportin 12.1.15+.apache-jspfromlib/ee8/andlib/ee11/to preventServiceLoaderinstantiation conflicts with SLF4J at runtime.Recursive Jar Search (
getJetty121Jar):getJetty121Jar(fileNamePattern)to check rootlib/and recursively search subdirectories (ee8/,ee11/,support/, etc.).jetty-servlet-api-4.0.9.jarandjakarta.servlet-api-6.1.0.jar.QuickStart Classpath Assembly (
getQuickStartClasspath):lib/eeX/presence to dynamically switch between legacy and 12.1.15 layouts.lib/eeX/, required annotation/auth APIs fromlib/eeX/support/, and ASM/SLF4J fromlib/support/.ContainerInitializerentries (e.g.TldScanner).JSP Compilation & User Libraries (
getJetty121JspJars):glassfish-jstlfromlib/eeX/, support libraries (apache-el,apache-jsp,jstl,jsp-api,jakarta.el, andwasp) fromlib/eeX/support/, and the custom AppEnginenologjar fromlib/eeX-apache-jsp/.jakarta.el.jakarta.el-api-6.0.1.jarinto EE11 JSP libraries, fixingRecordELResolverNoClassDefFoundError during runtime JSP compilation.wasp-4.0.4.jaris copied toWEB-INF/libwhen compiling JSPs soTldScanneris available when JSPs are present.Runtime Classpath (
getImplLibFiles):getImplLibFiles()to includeee8,ee8/support,ee11,ee11/support, andsupport.LinkedHashSetto deduplicate jars while maintaining deterministic classpath ordering.Closes #560
Closes #561