Migrate 'Sample Polylines' from a subgraph to a proto node#4063
Merged
Migrate 'Sample Polylines' from a subgraph to a proto node#4063
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the "Sample Polyline" node by inlining the segment length calculation logic directly into the sample_polyline proto node. This change removes the need for the legacy "Sample Polyline" wrapper network and the standalone subpath_segment_lengths node. Migration logic has been implemented to automatically upgrade existing documents using the old network to the new proto node while preserving input values. Additionally, several unused type mappings were removed from the node graph context. I have no feedback to provide.
Keavon
added a commit
that referenced
this pull request
Apr 29, 2026
oluseyi
pushed a commit
to oluseyi/Graphite
that referenced
this pull request
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs to have its memoization restored using the node macro to help with that.