Skip to content

Migrate 'Scatter Points' and 'Boolean Operation' from subgraphs to memoized proto nodes#4066

Merged
Keavon merged 1 commit intomasterfrom
unwrap-and-memoize-more-nodes
Apr 28, 2026
Merged

Migrate 'Scatter Points' and 'Boolean Operation' from subgraphs to memoized proto nodes#4066
Keavon merged 1 commit intomasterfrom
unwrap-and-memoize-more-nodes

Conversation

@Keavon
Copy link
Copy Markdown
Member

@Keavon Keavon commented Apr 28, 2026

No description provided.

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 6 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the "Boolean Operation" and "Scatter Points" (formerly "Poisson Disk Points") nodes by converting them from manual network definitions into standalone proto nodes using the memoize attribute. It includes migration logic to collapse legacy wrapper networks into these new proto nodes and updates internal references accordingly. Feedback suggests including the old proto node identifier in the migration aliases to ensure comprehensive document compatibility.

Comment thread editor/src/messages/portfolio/document_migration.rs
@Keavon Keavon merged commit 6c12d3e into master Apr 28, 2026
10 of 11 checks passed
@Keavon Keavon deleted the unwrap-and-memoize-more-nodes branch April 28, 2026 19:40
Keavon added a commit that referenced this pull request Apr 29, 2026
oluseyi pushed a commit to oluseyi/Graphite that referenced this pull request Apr 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant