Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the gradient system by decomposing the monolithic gradient table update into granular operations for stops, line endpoints, type, and spread method. It introduces new graph nodes (gradient_type and spread_method), updates the Gradient tool and Properties panel for better synchronization, and improves rendering stability for infinite backgrounds in SVG and Vello. Feedback suggests extracting a closure to reduce code duplication when calculating composed transforms in the utility types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This follows up #3989 by fixing document serialization, using separate nodes to set
"gradient_type"and"spread_method"attributes, and making the Gradient tool control those attributes plus"transform". This way, gradient tables are no longer relied upon for serialization, as we don't serialize attributes. This PR also clean up the control bar for the Gradient tool and adds a gradient widget there.