[php, python] big int issue #42

Activity

1. ncannasse commented on Dec 20, 2015

   

   ncannasse

   on Dec 20, 2015

   Member

   More actions

   It comes from there https://github.com/HaxeFoundation/hscript/blob/master/hscript/Parser.hx#L980-L989, any idea how to fix this @Simn ?
2. Simn commented on Dec 20, 2015

   

   Simn

   on Dec 20, 2015

   Member

   More actions

   Does it work if the Haxe 2 version with Int32 is used?
3. ncannasse commented on Dec 20, 2015

   

   ncannasse

   on Dec 20, 2015

   Member

   More actions

   I'm not sure, we didn't unit test it on PHP/Python at this time I think
4. Simn commented on Dec 20, 2015

   

   Simn

   on Dec 20, 2015

   Member

   More actions

   Just tested, it parses the correct value when using Int32, but with CInt taking an Int argument that doesn't help much. Even when changing that to Int32 it doesn't make it through the interpreter though, presumably because expr just assigns it to Dynamic when returning.
5. ncannasse commented on Dec 20, 2015

   

   ncannasse

   on Dec 20, 2015

   Member

   More actions

   Maybe doing & 0xFFFFFFFF on these platforms would work ?
6. ncannasse

   added a commit that references this issue on May 6, 2017

   fix overflow on bigint platforms (close #42)

   This issue will close once commit 8b9b244 is merged into the 'master' branch.

   8b9b244