fix: Preserve block tags to preserve reconstruction/execution order#1312
Open
jasmith-hs wants to merge 6 commits intomasterfrom
Open
fix: Preserve block tags to preserve reconstruction/execution order#1312jasmith-hs wants to merge 6 commits intomasterfrom
jasmith-hs wants to merge 6 commits intomasterfrom
Conversation
…properly when there are values used in blocks that have been deferred in their extends roots
rewaddell
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simpler and more accurate fix to the bug that #1307 targeted (in that this also handles deferred modifications).
There is a bug in how reconstructed output is rendered when there are block tags due to the order of execution. Block tags are always evaluated last, even if they'll show up higher in a template
(I use
{# \d+ #}in the following examples to show the order in which the lines are evaluated)Child
Parent
If reconstructed directly, we'd end up with:
Which results in
foo_barnot being reconstructed in time. However, if we preserve the blocks, we can also preserve the execution order: