Skip to content

SCENARIO: dc_title and dc_isPartOf may include colons (see #312).#413

Merged
benel merged 4 commits into
mainfrom
fix-312
May 13, 2026
Merged

SCENARIO: dc_title and dc_isPartOf may include colons (see #312).#413
benel merged 4 commits into
mainfrom
fix-312

Conversation

@Bleumms

@Bleumms Bleumms commented Mar 31, 2026

Copy link
Copy Markdown
Contributor

Co-authored-by: Nyrco nicolas.ranvoisy@utt.fr
Co-authored-by: PA0Lbst pierre_alexandre.despaquis@utt.fr

@Bleumms Bleumms requested a review from benel as a code owner March 31, 2026 15:46
@benel

benel commented Apr 7, 2026

Copy link
Copy Markdown
Member

@Bleumms @PA0Lbst @Nyrco Thank you for your contribution.

Well done for the commit format and the updated scenario!

As you noticed, your modified scenario already fails (which is good) so you don't need to update tests. Your next step is to add (to your branch) an other commit with the implementation of your FIX.

@PA0Lbst PA0Lbst linked an issue Apr 21, 2026 that may be closed by this pull request
dc_title and dc_isPartOf may include colons #312
Closed
4 tasks
benel
benel requested changes Apr 22, 2026
View reviewed changes

@benel benel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @Bleumms @Nyrco @PA0Lbst.

Don't forget to fill the license agreement:

We, [FILL WITH FULL NAMES], hereby grant to Hyperglosae maintainers the right to publish our contribution under the terms of any licenses the Free Software Foundation classifies as Free Software Licenses.

@PA0Lbst Didn't you have coauthors for the FIX ?

@Bleumms

Bleumms commented May 12, 2026

Copy link
Copy Markdown
Contributor Author

There are no difficulties related to this commit, just Github did not take the co-author without reason.

We, Emeline NEROT, Nicolas RANVOISY, Pierre-Alexandre DESPAQIS, hereby grant to Hyperglosae maintainers the right to publish our contribution under the terms of any licenses the Free Software Foundation classifies as Free Software Licenses.

Bleumms and others added 4 commits May 13, 2026 10:52
@Bleumms @Nyrco
@PA0Lbst @benel
SCENARIO: dc_title and dc_isPartOf may include colons (see #312).
4bdc1a4 
Co-authored-by: Nyrco <nicolas.ranvoisy@utt.fr>
Co-authored-by: PA0Lbst <pierre_alexandre.despaquis@utt.fr>
@PA0Lbst @Nyrco
@Bleumms @benel
TEST: dc_title and dc_isPartOf may include colons (see #312).
5daaa36 
Co-authored-by: Nyrco <nicolas.ranvoisy@utt.fr>
Co-authored-by: Bleumms <emeline.nerot@utt.fr>
@PA0Lbst @benel
FIX: dc_title and dc_isPartOf may include colons (fixes #312).
a5831ea 
Co-authored-by: Nyrco <nicolas.ranvoisy@utt.fr>
Co-authored-by: Bleumms <emeline.nerot@utt.fr>

# Conflicts:
#	frontend/src/components/Metadata.jsx
@PA0Lbst @Bleumms @benel
PROCESS: More permissive acceptance test.
ea476ec 
Co-authored-by: Bleumms <emeline.nerot@utt.fr>
@benel benel merged commit ea476ec into main May 13, 2026
3 checks passed
@benel benel deleted the fix-312 branch May 13, 2026 12:12
@benel

benel commented May 13, 2026

Copy link
Copy Markdown
Member

@Bleumms @Nyrco @PA0Lbst
Your contribution is live on the production server! Well done 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benel benel benel requested changes

Assignees

@Nyrco Nyrco

@PA0Lbst PA0Lbst

@Bleumms Bleumms

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

dc_title and dc_isPartOf may include colons

4 participants

@Bleumms @benel @Nyrco @PA0Lbst