Replace author Edit button with new window link icon#4856
Merged
Conversation
frjo
reviewed
May 21, 2026
| {% trans "Edit" %} | ||
| <a class="link" href="{% url 'wagtailusers_users:edit' object.user_id %}" target="_blank"> | ||
| {% heroicon_mini "arrow-top-right-on-square" class="inline align-text-bottom size-4" %} | ||
| </a> |
Member
There was a problem hiding this comment.
That icon usually is used for external links. Can we not just make it underline?
Not to fond of target="_blank" but we use it in 25 other places already.
Contributor
Author
There was a problem hiding this comment.
Was using some of the precedent here to convey to the staff member that this is going to remove them from their current workflow, as I can see a lot of them clicking it accidentally thinking it'll allow for filtering by applicant or something similar. Can make the name a link if you feel that's more intuitive though
Member
There was a problem hiding this comment.
Ok, let leave it as is. But we do need to add a "title" attribute to the link to make it accessible. Something like "Edit user account".
frjo
approved these changes
May 22, 2026
frjo
added
Type: Enhancement
wes-otf
added a commit
that referenced
this pull request
May 25, 2026
<!-- Thanks for contributing to Hypha! Please ensure your contributions pass all necessary linting/testing and that the appropriate documentation has been updated. --> <!-- Describe briefly what your pull request changes. If this is resolving an issue, please specify below via "Fixes #<Github Issue ID>" --> Addressing the conversation [here](#4380 (comment)). Making the link to the user's wagtail admin page a little less confusing now that the "Change Author" feature exists. Also made this open in a new tab. Feels a bit more intuitive *before* <img width="160" height="92" alt="Screenshot 2026-05-21 at 09 52 43" src="https://github.com/user-attachments/assets/164f4523-983a-4ee5-9ed2-8c7bbfab9de5" /> *after* <img width="160" height="92" alt="Screenshot 2026-05-21 at 09 51 55" src="https://github.com/user-attachments/assets/afa00bac-e232-464a-bd8c-2ae54e5970d5" />
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing the conversation here. Making the link to the user's wagtail admin page a little less confusing now that the "Change Author" feature exists. Also made this open in a new tab. Feels a bit more intuitive
before
after