Repository navigation
Add configurable Axum buffered JSON body limits #407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ChristianPavilonis
wants to merge
6
commits into
issue-392-396-production-hosting-spec
from
issue-393-buffered-body-limit-spec
+2,167
−33
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
e867c12
feat(axum): configure buffered JSON body limits
ChristianPavilonis cb617a3
Merge corrected lower-stack fixture lock
ChristianPavilonis 90b5e6a
Merge corrected lower-stack feature and CI contracts
ChristianPavilonis 4856d95
fix(ci): sync buffered-body fixture MIME dependency locks
ChristianPavilonis b082ae6
Merge managed demo logging regression alignment
ChristianPavilonis 8a2a0b7
Merge native-only scaffold correction into body-limit stack
ChristianPavilonis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔧 Breaking changes aren't flagged, and "representation unchanged" is inaccurate
For existing Axum apps, this entry changes behavior that the CHANGELOG normally marks with
- **Breaking:**(see "Policy-Aware Axum Servers"):The Axum
Json<T>/ValidatedJson<T>default drops from 8 MiB to 2 MiB.Explicit caps above the ceiling are now silently lowered to it and return 413:
json_within(N)andValidatedJsonWithin<T, N>;application/json/+jsonrequests:body_bytes(N),form_within(N), the Form family, and pre-dispatchbody_bytes/transform_body(max_input, ..)."Explicit application caps may tighten the ceiling" hides that clamp.
New public method:
Body::with_buffered_json_policy.Body'sDebugoutput gains aningress_bufferfield, andBodygrows from 40 to 64 bytes, so "representation remain unchanged" doesn't hold.Please also update the rustdoc that now describes the wrong behavior:
DEFAULT_INBOUND_JSON_BYTES("accepted by JSON extractors (8 MiB)",context.rs:32)body_bytes("under the caller's byte cap",context.rs:343)json_within("Buffers at mostmaxbytes",context.rs:654)All three should mention the native ceiling.