Repository navigation
Add pluggable native Geo providers and protected CloudFront ingress #439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
590dff9
93b4177
c8ee48f
5ddc0d3
6f3ebdb
8663acc
1df9f7a
22741b6
7045bcf
414e52a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -19,6 +19,8 @@ axum = [ | |
| "dep:tokio", | ||
| "dep:tower", | ||
| "dep:futures-util", | ||
| "dep:getrandom", | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ⛏ Duplicate feature entries
|
||
| "dep:ipnet", | ||
| "dep:http-body", | ||
| "dep:hyper", | ||
| "dep:hyper-util", | ||
|
|
@@ -35,6 +37,7 @@ aws-stores = ["aws-appconfig-agent", "aws-secrets-manager"] | |
| aws-dynamodb = ["axum", "edgezero-store-aws/dynamodb-kv"] | ||
| celld-config = ["axum", "edgezero-store-celld/config"] | ||
| celld-kv = ["axum", "edgezero-store-celld/kv"] | ||
| geo-cloudfront = ["axum"] | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🤔 Does the It gates Design section 7 asks for the built-in to be default-off, and |
||
| cli = [ | ||
| "native-bindings", | ||
| "dep:edgezero-adapter", | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔧 Geo steps run in every host-test matrix leg
Every neighbouring step here is guarded with
if: matrix.suite == 'workspace', but the nine new Geo steps (lines 189-219) have no guard. Run 42924133045 shows all nine executed in theworkspace,cli,axumandapp-demolegs, so the dependency script and four distinct Axum feature builds run four times per push.Add the guard to each step:
(or
matrix.suite == 'axum'if they are meant to live with the Axum leg).