Skip to content

feat: adding new field for smtp config and source creation - #83

Open
harini-ibm wants to merge 1 commit into
mainfrom
smtp-config
Open

harini-ibm wants to merge 1 commit into
mainfrom
smtp-config

Conversation

@harini-ibm

@harini-ibm harini-ibm commented Jul 11, 2026 •

Copy link
Copy Markdown
Collaborator

PR summary

Fixes: https://github.ibm.com/Notification-Hub/planning/issues/20852
https://github.ibm.com/Notification-Hub/adopters/issues/168

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

What is the current behavior?

What is the new behavior?

  1. including the source field to create source for vpc source
  2. admin_emails field has been added for create and update smtp configuration.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

nitish-sudo
nitish-sudo previously approved these changes Jul 14, 2026

This branch was successfully deployed

1 active deployment
ci — 7183eec0 Deployed Jul 14, 2026 by harini-ibm via test (3.10) #67
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants