Skip to content

build: drop release-it - #436

Open
abmusse wants to merge 1 commit into
mainfrom
drop-release-it
Open

abmusse wants to merge 1 commit into
mainfrom
drop-release-it

Conversation

@abmusse

@abmusse abmusse commented Sep 30, 2026

Copy link
Copy Markdown
Member

No description provided.

@abmusse
abmusse requested a review from kadler September 30, 2026 00:34
@kadler

kadler commented Oct 1, 2026

Copy link
Copy Markdown
Member

If we were to add a .npmrc to git, I think we could simplify the instructions:

preid=rc
tag-version-prefix=
message=chore: release %s

When creating the RC, determine whether the next version will bump the major, minor, or patch and run the appropriate pre-version, eg. npm version preminor. Then for further RCs, npm version prerelease. Finally npm version release to go from RC to final.

The tag-version-prefix and message values then keeps the autogenerated tag names and git commit messages consistent with our previous convention. (The default is just to commit the version and the tag name is prefixed with "v").

Comment thread docs/RELEASE.md
Comment on lines +38 to +39
git push origin main
git push origin v$(node -p "require('./package.json').version")

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
git push origin main
git push origin v$(node -p "require('./package.json').version")
git push origin main v$(node -p "require('./package.json').version")

This can be done in one command.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, git describe --tags --abbrev=0 will give the latest tag so you don't need to prefix the version or call node at all.

git push origin main $(git describe --tags --abbrev=0)

@kadler

kadler commented Oct 1, 2026

Copy link
Copy Markdown
Member

Oh, looks like here we want the v prefix on the tag name. I was looking at idb-connector convention.

@kadler

kadler commented Oct 1, 2026

Copy link
Copy Markdown
Member

Might be worth adding sign-git-tag=true to the npmrc to require signed tags. We have tended to make lightweight tags in the past, but might be good to switch to signed ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants