test(problem): add regression tests for Problem.simulate()#253
Open
g-braeunlich wants to merge 3 commits into
Open
test(problem): add regression tests for Problem.simulate()#253g-braeunlich wants to merge 3 commits into
g-braeunlich wants to merge 3 commits into
Conversation
57c04be to
16856a5
Compare
043d6c5 to
12782cf
Compare
Collaborator
Author
|
Also added 2 maintenance commits:
|
Collaborator
Author
|
Other points to discuss:
|
markfuge
approved these changes
Jun 9, 2026
markfuge
left a comment
Member
There was a problem hiding this comment.
Overall LGTM. We can discuss the open points you mentioned briefly at the next biweekly.
Background: numpy deprecated numpy.cross / numpy.linalg.cross for 2D vectors
ea7ded1 to
a8560ed
Compare
a8560ed to
1dde049
Compare
Collaborator
Author
|
@markfuge I now have implemented things as discussed: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add regression tests for
Problem.simulate()which check against reference values.Fixes #159
Type of change
Please delete options that are not relevant.
Checklist:
pre-commitchecks withpre-commit run --all-filesruff check .andruff formatmypy .Reviewer Checklist: