feat(): fix circular and linear progress values in Safari#17362
Open
adrianptrv wants to merge 1 commit into
Open
feat(): fix circular and linear progress values in Safari#17362adrianptrv wants to merge 1 commit into
adrianptrv wants to merge 1 commit into
Conversation
adrianptrv
added
❌ status: awaiting-test
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes Safari-specific animation behavior for Circular and Linear Progress by changing typed custom properties used for the counter label from <integer> to <number>, enabling smooth interpolation, and rounding the interpolated values back to whole numbers when feeding CSS counters.
Changes:
- Update
@propertydefinitions for--_progress-integer/--_progress-fractionto use<number>so Safari can transition them smoothly. - Adjust
counter-resetin linear and circular progress themes to useround(down, ...)so the counter always receives integer values during transitions.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| projects/igniteui-angular/core/src/core/styles/themes/_core.scss | Changes typed custom properties for progress counters from <integer> to <number> to enable smooth transitions in Safari. |
| projects/igniteui-angular/core/src/core/styles/components/progress/linear/_linear-theme.scss | Rounds interpolated progress custom properties before applying them to counter-reset to keep the counter value valid while animating. |
| projects/igniteui-angular/core/src/core/styles/components/progress/circular/_circular-theme.scss | Same counter rounding approach as linear progress, applied to the circular progress label counter reset. |
desig9stein
added
💥 status: in-test
This comment was marked as resolved.
This comment was marked as resolved.
desig9stein
added
✅ status: verified
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17210
Description
The issue occurred because Safari cannot perform smooth transitions on integer properties and jumps directly to the provided value. By changing those custom properties to , Safari transitions them normally, and the counter value animates consistently across all browsers.
Type of Change (check all that apply):
Component(s) / Area(s) Affected:
Circular and Linear Progress
How Has This Been Tested?