fix(grid): prevent NaN column width when hidden grid has all columns sized - 22.0.x - #17461
Merged
Conversation
…into vkombov/fix-17418-22.0.x
viktorkombov
added
❌ status: awaiting-test
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a grid autosizing edge case where getPossibleColumnWidth() could return NaNpx when the grid is hidden (no measurable width) and all visible columns already have explicit/constrained widths, which can poison cached widths and lead to repeated sizing/reflow.
Changes:
- Add a guard in
getPossibleColumnWidth()to return the"0px"sentinel in the problematic hidden-grid/sum-width fallback scenario. - Add a unit test reproducing the hidden-wrapper case and asserting no
NaNwidths are derived.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| projects/igniteui-angular/grids/grid/src/grid-base.directive.ts | Adds an early-return guard to prevent NaN possible widths when the grid width is derived from summing column widths. |
| projects/igniteui-angular/grids/grid/src/column.spec.ts | Adds a regression test that hides the grid via a wrapper and verifies derived widths remain finite. |
ChronosSF
added
✅ status: verified
ChronosSF
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17418
Description
getPossibleColumnWidth()divided the available width bycolumnsToSizewhen every visible column already had an explicit or constrained width.When the grid is hidden through a wrapper and has no measurable width,
calcWidthfalls back to the sum of the column widths. In this case,computedWidthequalssumExistingWidthsandcolumnsToSizeis0, resulting in0 / 0 = NaN. This then poisons the cached column widths and can cause an infinite sizing loop.When the grid is using the column-width sum fallback and there are no columns left to auto-size, return the
"0px"sentinel so the existing valid column widths are preserved.Motivation / Context
Type of Change (check all that apply):
Component(s) / Area(s) Affected:
How Has This Been Tested?
Test Configuration:
Screenshots / Recordings
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)