ci(lint): enable lint in CI runs, fix some mpc package errors, suppr…#1630
Merged
damyanpetev merged 7 commits intomasterfrom Apr 20, 2026
Merged
ci(lint): enable lint in CI runs, fix some mpc package errors, suppr…#1630damyanpetev merged 7 commits intomasterfrom
damyanpetev merged 7 commits intomasterfrom
Conversation
damyanpetev
commented
Apr 20, 2026
Comment on lines
+155
to
+157
| 'packages/igniteui-mcp/**/*.test.ts', | ||
| 'packages/igniteui-mcp/igniteui-doc-mcp/scripts/**/*', | ||
| 'packages/igniteui-mcp/igniteui-doc-mcp/vitest.config.ts', |
Member
Author
There was a problem hiding this comment.
@dkalinovInfra Wouldn't mind those being properly configured into some tsconfg so we can point the lint config to read them (since now they are not in one and the TS parser fails, but it seems configurable https://typescript-eslint.io/packages/parser/#project)
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the repo’s CI to run ESLint during GitHub Actions runs and makes a few formatting/type-import tweaks in the igniteui-doc-mcp package to satisfy linting.
Changes:
- Add a
yarn lintstep to the Node.js CI workflow. - Update ESLint configuration with additional overrides/ignore patterns for the
igniteui-mcparea. - Apply small formatting/import cleanups in
igniteui-doc-mcpTypeScript sources.
Reviewed changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/igniteui-mcp/igniteui-doc-mcp/src/tools/handlers.ts | Whitespace/formatting cleanup in search output formatting. |
| packages/igniteui-mcp/igniteui-doc-mcp/src/lib/react-json-parser.ts | Whitespace/formatting cleanup. |
| packages/igniteui-mcp/igniteui-doc-mcp/src/lib/api-doc-loader.ts | Consolidate type/value imports; whitespace cleanup. |
| eslint.config.mjs | Add igniteui-doc-mcp override + expand ignore patterns for igniteui-mcp. |
| .github/workflows/nodejs.yml | Run yarn lint in CI. |
Comments suppressed due to low confidence (1)
.github/workflows/nodejs.yml:37
yarn testwill already run thepretestlifecycle script, which in this repo executesnpm run lint(see package.json scripts). Adding a separateLintstep here makes lint run twice in CI, increasing runtime and potentially creating confusion if one step changes config/env. Consider removing this step, or alternatively remove lint frompretestif you want lint as an explicit CI stage.
- name: Lint
run: yarn lint
- name: Test
run: |
yarn config set scripts-prepend-node-path auto
yarn test
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kdinev
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ess parts
Closes # .
Additional information related to this pull request: