Skip to content

ci(lint): enable lint in CI runs, fix some mpc package errors, suppr…#1630

Merged
damyanpetev merged 7 commits intomasterfrom
dpetev/ci-lint
Apr 20, 2026
Merged

ci(lint): enable lint in CI runs, fix some mpc package errors, suppr…#1630
damyanpetev merged 7 commits intomasterfrom
dpetev/ci-lint

Conversation

@damyanpetev
Copy link
Copy Markdown
Member

…ess parts

Closes # .

Additional information related to this pull request:

@damyanpetev damyanpetev marked this pull request as ready for review April 20, 2026 15:58
Copilot AI review requested due to automatic review settings April 20, 2026 15:58
@coveralls
Copy link
Copy Markdown

coveralls commented Apr 20, 2026

Coverage Status

coverage: 86.278%. remained the same — dpetev/ci-lint into master

Comment thread eslint.config.mjs
Comment on lines +155 to +157
'packages/igniteui-mcp/**/*.test.ts',
'packages/igniteui-mcp/igniteui-doc-mcp/scripts/**/*',
'packages/igniteui-mcp/igniteui-doc-mcp/vitest.config.ts',
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dkalinovInfra Wouldn't mind those being properly configured into some tsconfg so we can point the lint config to read them (since now they are not in one and the TS parser fails, but it seems configurable https://typescript-eslint.io/packages/parser/#project)

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the repo’s CI to run ESLint during GitHub Actions runs and makes a few formatting/type-import tweaks in the igniteui-doc-mcp package to satisfy linting.

Changes:

  • Add a yarn lint step to the Node.js CI workflow.
  • Update ESLint configuration with additional overrides/ignore patterns for the igniteui-mcp area.
  • Apply small formatting/import cleanups in igniteui-doc-mcp TypeScript sources.

Reviewed changes

Copilot reviewed 3 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
packages/igniteui-mcp/igniteui-doc-mcp/src/tools/handlers.ts Whitespace/formatting cleanup in search output formatting.
packages/igniteui-mcp/igniteui-doc-mcp/src/lib/react-json-parser.ts Whitespace/formatting cleanup.
packages/igniteui-mcp/igniteui-doc-mcp/src/lib/api-doc-loader.ts Consolidate type/value imports; whitespace cleanup.
eslint.config.mjs Add igniteui-doc-mcp override + expand ignore patterns for igniteui-mcp.
.github/workflows/nodejs.yml Run yarn lint in CI.
Comments suppressed due to low confidence (1)

.github/workflows/nodejs.yml:37

  • yarn test will already run the pretest lifecycle script, which in this repo executes npm run lint (see package.json scripts). Adding a separate Lint step here makes lint run twice in CI, increasing runtime and potentially creating confusion if one step changes config/env. Consider removing this step, or alternatively remove lint from pretest if you want lint as an explicit CI stage.
      - name: Lint
        run: yarn lint
      - name: Test
        run: |
          yarn config set scripts-prepend-node-path auto
          yarn test

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread eslint.config.mjs
Comment thread eslint.config.mjs
@damyanpetev damyanpetev merged commit 670c30d into master Apr 20, 2026
3 checks passed
@damyanpetev damyanpetev deleted the dpetev/ci-lint branch April 20, 2026 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants