refactor(upgrade-packages): always keep igniteui-react; upgrade igniteui-react-dockmanager instead#1638
Merged
damyanpetev merged 9 commits intomasterfrom Apr 21, 2026
Conversation
Agent-Logs-Url: https://github.com/IgniteUI/igniteui-cli/sessions/9727f8f7-1685-48d6-9c8e-7d9dbcffce1f Co-authored-by: Hristo313 <57346540+Hristo313@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update igniteui-react to be non-upgradable and replace with dock-manager
Stop upgrading Apr 20, 2026
igniteui-react; upgrade igniteui-react-dockmanager instead
|
coverage: 86.335% (+0.002%) from 86.333% — copilot/update-igniteui-react-to-dock-manager into master |
damyanpetev
reviewed
Apr 21, 2026
…ing update Agent-Logs-Url: https://github.com/IgniteUI/igniteui-cli/sessions/a543e22c-5dc7-472a-8878-405011cc8402 Co-authored-by: damyanpetev <3198469+damyanpetev@users.noreply.github.com>
damyanpetev
reviewed
Apr 21, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the upgrade-packages/workspace migration logic to stop treating igniteui-react as a licensable/upgradeable package and instead migrate the React Dock Manager package to its scoped Infragistics equivalent.
Changes:
- Removed the
igniteui-react→@infragistics/igniteui-reactupgrade mapping and constants. - Added
igniteui-react-dockmanager→@infragistics/igniteui-react-dockmanagerto the upgradeable package map. - Updated/extended unit tests and changelog to reflect the new React upgrade behavior.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
spec/unit/update-spec.ts |
Updates React workspace upgrade expectations (keep igniteui-react; migrate React Dock Manager). |
spec/unit/packageResolve-spec.ts |
Adds coverage for detecting igniteui-react-dockmanager as upgradeable. |
packages/core/update/package-resolve.ts |
Adjusts the upgradeable package mapping/constants for React packages. |
CHANGELOG.md |
Documents the adjusted React licensing migration behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
damyanpetev
changed the title
igniteui-react; upgrade igniteui-react-dockmanager insteadigniteui-react; upgrade igniteui-react-dockmanager instead
damyanpetev
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
upgrade-packagesstill treatedigniteui-reactas upgradable to@infragistics/igniteui-react, but that package is deprecated andigniteui-reactis now MIT. This PR removes that upgrade path and switches React dock manager upgrades toigniteui-react-dockmanager->@infragistics/igniteui-react-dockmanager.Upgrade mapping changes
igniteui-react->@infragistics/igniteui-reactfromUPGRADEABLE_PACKAGES.igniteui-react-dockmanager->@infragistics/igniteui-react-dockmanager.FEED_REACTconstant frompackage-resolve.ts.React upgrade behavior updates
updateWorkspaceexpectations soigniteui-reactremains unchanged inpackage.json.igniteui-react-grids) intact.Unit test alignment
igniteui-react-dockmanageringetUpgradeablePackages().Changelog update
CHANGELOG.mdto document thatupgrade-packagescommand/schematic licensing migration behavior is aligned for React 19.4.0+ (migratesigniteui-react-dockmanager, does not migrateigniteui-react).> [!WARNING]
>
>