Skip to content

Update ai-config skills copy messaging w/ up-to-date/failed, don't call in step-by-step#1641

Merged
damyanpetev merged 2 commits intomasterfrom
dpetev/refactor-skills-copy-messaging
Apr 20, 2026
Merged

Update ai-config skills copy messaging w/ up-to-date/failed, don't call in step-by-step#1641
damyanpetev merged 2 commits intomasterfrom
dpetev/refactor-skills-copy-messaging

Conversation

@damyanpetev
Copy link
Copy Markdown
Member

@damyanpetev damyanpetev commented Apr 20, 2026

Description

Update ai-config skills copy messaging to account for up-to-date files and possible failures.
Also made optional and skipped when called from Step-by-step, since the skills are in the template anyway ATM.

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Refactoring / code cleanup
  • Build / CI configuration change

Affected Packages

  • igniteui-cli (packages/cli)
  • @igniteui/cli-core (packages/core)
  • @igniteui/angular-templates (packages/igx-templates)
  • @igniteui/angular-schematics (packages/ng-schematics)
  • @igniteui/mcp-server (packages/igniteui-mcp)

Checklist

  • I have tested my changes locally (npm run test)
  • I have built the project successfully (npm run build)
  • I have run the linter (npm run lint)
  • I have added/updated tests as needed
  • My changes do not introduce new warnings or errors

Additional Context

Copilot AI review requested due to automatic review settings April 20, 2026 14:45
@damyanpetev damyanpetev requested review from Marina-L-Stoyanova and removed request for Copilot April 20, 2026 14:45
@coveralls
Copy link
Copy Markdown

coveralls commented Apr 20, 2026

Coverage Status

coverage: 86.278% (+0.09%) from 86.193% — dpetev/refactor-skills-copy-messaging into master

Copilot AI review requested due to automatic review settings April 20, 2026 15:18
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the ai-config workflow to better report AI skills synchronization results (up-to-date vs updated vs failed) and skips copying skills during the step-by-step project flow (since skills are currently included in templates).

Changes:

  • Refactors copyAISkillsToProject() to return structured copy results (found/skipped/failed) and only write when content differs.
  • Updates CLI ai-config output messaging based on copy results (no source, failures, up-to-date).
  • Adjusts step-by-step flow to call ai-config without skills, plus corresponding unit test updates.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
spec/unit/ai-skills-spec.ts Adds spies for logging and a new test for “up-to-date” skip behavior.
spec/unit/PromptSession-spec.ts Updates expectations to ensure aiConfig.configure(false) is used from PromptSession.
packages/core/util/ai-skills.ts Changes skills copy to diff-based writes and returns a structured result object.
packages/cli/lib/commands/ai-config.ts Updates user-facing messaging and makes skills copying optional via configure(skills = true).
packages/cli/lib/PromptSession.ts Skips skills configuration during step-by-step by calling aiConfigure(false).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/core/util/ai-skills.ts
Comment thread packages/cli/lib/commands/ai-config.ts Outdated
Comment thread packages/core/util/ai-skills.ts
Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 20, 2026

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • www.google-analytics.com
    • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node node packages/cli/bin/execute.js new --help 3c49�� (dns block)
    • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node node packages/cli/bin/execute.js config --help de_modules/.bin/tsx (dns block)
    • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node node packages/cli/bin/execute.js generate --help (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

damyanpetev and others added 2 commits April 20, 2026 18:51
@damyanpetev damyanpetev force-pushed the dpetev/refactor-skills-copy-messaging branch from 4b91dc9 to 56339f0 Compare April 20, 2026 15:51
@damyanpetev damyanpetev merged commit a234dfc into master Apr 20, 2026
3 checks passed
@damyanpetev damyanpetev deleted the dpetev/refactor-skills-copy-messaging branch April 20, 2026 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants