Skip to content

Mstoyanova/update mcp config agent agnostic restore#1684

Open
Marina-L-Stoyanova wants to merge 5 commits intomasterfrom
mstoyanova/update-mcp-config-agent-agnostic-restore
Open

Mstoyanova/update mcp config agent agnostic restore#1684
Marina-L-Stoyanova wants to merge 5 commits intomasterfrom
mstoyanova/update-mcp-config-agent-agnostic-restore

Conversation

@Marina-L-Stoyanova
Copy link
Copy Markdown
Contributor

@Marina-L-Stoyanova Marina-L-Stoyanova commented May 11, 2026

…date related prompts

Description

enhance MCP configuration for multiple coding assistants

Related Issue

Closes #

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Refactoring / code cleanup
  • Build / CI configuration change

Affected Packages

  • igniteui-cli (packages/cli)
  • @igniteui/cli-core (packages/core)
  • @igniteui/angular-templates (packages/igx-templates)
  • @igniteui/angular-schematics (packages/ng-schematics)
  • @igniteui/mcp-server (packages/igniteui-mcp)

Checklist

  • [x ] I have tested my changes locally (npm run test)
  • I have built the project successfully (npm run build)
  • I have run the linter (npm run lint)
  • I have added/updated tests as needed
  • My changes do not introduce new warnings or errors

Additional Context

image

Marina-L-Stoyanova and others added 2 commits May 11, 2026 14:36
…date related prompts

Co-authored-by: Copilot <copilot@github.com>
…and enhance related prompts

Co-authored-by: Copilot <copilot@github.com>
@Marina-L-Stoyanova Marina-L-Stoyanova marked this pull request as ready for review May 11, 2026 12:08
Copilot AI review requested due to automatic review settings May 11, 2026 12:08
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the AI configuration flow to make MCP server configuration assistant-agnostic (VS Code vs Cursor/Claude Code/etc.) and to separate MCP configuration from AI “skills and instructions” generation.

Changes:

  • Adds assistant-specific MCP config targets (path + root key) and updates MCP writer to support multiple assistants.
  • Extends both the CLI command and Angular schematic to accept/prompt for “assistant(s)” separately from “agent(s)”.
  • Updates/extends unit and schematic tests and schema prompts/messages to reflect the split between MCP configuration and skills/instructions.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
spec/unit/ai-config-spec.ts Updates CLI unit tests for new assistant/agent prompting and MCP behavior.
packages/ng-schematics/src/cli-config/index.ts Updates schematic logic to configure MCP per selected assistant(s).
packages/ng-schematics/src/cli-config/index_spec.ts Adds schematic tests for assistant-specific MCP output paths and root keys.
packages/ng-schematics/src/cli-config/ai-config-schema.json Adds assistant option (prompt + enum) and updates agent prompt messaging.
packages/core/util/mcp-config.ts Introduces assistant MCP config map and changes addMcpServers to be assistant-based.
packages/cli/lib/commands/ai-config.ts Adds assistant prompting/selection and routes MCP config generation accordingly.
Comments suppressed due to low confidence (1)

packages/cli/lib/commands/ai-config.ts:143

  • The handler configures MCP servers via configureMCP(assistants) and then calls configure(agents) which also configures MCP (defaulting to VS Code). This causes duplicate writes and ignores the user’s assistant selection (e.g. selecting --assistant none or choosing “None” interactively still results in VS Code MCP configuration). Pass the selected assistants into configure(...) and/or refactor so MCP is configured exactly once and respects an explicit “none” selection.
		if (!assistants?.length) {
			assistants = await promptForAssistant();
		}
		if (!agents?.length) {
			agents = await promptForAgents();
		}

		GoogleAnalytics.post({
			t: "event",
			ec: "$ig ai-config",
			ea: `agent: ${agents.join(", ") || "none"}`
		});

		if (assistants.length) {
			configureMCP(assistants);
		}

		if (!agents.length) {
			Util.log("No AI configuration selected. Skipping.");
			return;
		}
		await configure(agents);
	}

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

import { chain, FileDoesNotExistException, Rule, SchematicContext, Tree } from "@angular-devkit/schematics";
import { RunSchematicTask } from "@angular-devkit/schematics/tasks";
import { addClassToBody, addMcpServers, AIAgentTarget, App, copyAgentInstructionFiles, copyAISkillsToProject, FormatSettings, McpServerEntry, NPM_ANGULAR, resolvePackage, TEMPLATE_MANAGER, TypeScriptAstTransformer, TypeScriptUtils, VS_CODE_MCP_PATH } from "@igniteui/cli-core";
import { addClassToBody, addMcpServers, AIAgentTarget, AiCodingAssistant, App, copyAgentInstructionFiles, copyAISkillsToProject, FormatSettings, McpServerEntry, NPM_ANGULAR, resolvePackage, TEMPLATE_MANAGER, TypeScriptAstTransformer, TypeScriptUtils, VS_CODE_MCP_PATH } from "@igniteui/cli-core";
Comment thread packages/cli/lib/commands/ai-config.ts Outdated
Comment on lines +87 to +93
// TODO: check Util.canPrompt() and assign defaults
const selected = await InquirerWrapper.checkbox({
message: "Which coding assistants should MCP servers be configured for?",
required: true,
choices: AI_ASSISTANT_CHECKBOX_CHOICES
});
return selected.includes("none") ? [] : selected as AiCodingAssistant[];
Comment thread packages/cli/lib/commands/ai-config.ts Outdated
Comment on lines +109 to +115
choices: AI_ASSISTANT_CHOICES,
type: "array"
}),
async handler(argv: ArgumentsCamelCase) {
let agents = argv.agent as AIAgentTarget[] | undefined;
let assistants = argv.assistant as AiCodingAssistant[] | undefined;

Comment thread spec/unit/ai-config-spec.ts Outdated
Marina-L-Stoyanova and others added 3 commits May 11, 2026 16:50
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants