Improve UX for Battery Notifications settings and toggle feature

[tituscmd]

Battery Notifications are now under a master toggle "Battery Notifications" inside of Notification Settings. Activating this feature unlocks the customizable options available in the Battery settings menu. The settings in the Battery Settings menu persist, but all battery notifications are deactivated when the master toggle is off.
This new master toggle also appears as an option in the SetUpDetailsView.

ToDo:

• Include hyperlink to Notifications Settings menu in "Battery Notifications Disabled" popup
• Change location of ANCS warning text from below "Send to Watch" toggle to appropriate place

[liamcharger]

Welcome aboard, @tituscmd 🫡

I played around a little bit, but just ended up using a conditional string in the footer for the ANCS message

For the link to the notification settings, I just used a good old fashion NavigationLink. If it wasn't working for you it was most likely from the preview not being wrapped in a NavigationStack (or similar)

I also just changed the percentage label (max) to say 95% as that reflects the true max value

[liamcharger]

After thinking about it for a little while, a master toggle for battery notifications might be a bit a tad bit over engineered...

It opens up a can of worms about the best behavior... E.g. hiding the battery section entirely from the home view, adding the message and the link like what we have now, or something else entirely

As a user, I can turn off battery notifications by untoggling the three options (full charge, low battery, and custom percentage notifs). And it would be more predictable if I didn't have to go back and forth between notification settings and battery settings. So I think it might be best to either move it to the top of the battery list items, or remove it altogether. I'm leaning towards the latter...

Wdyt?

[tituscmd]

It opens up a can of worms about the best behavior... E.g. hiding the battery section entirely from the home view, adding the message and the link like what we have now, or something else entirely

Yeah, I thought about all those possibilities as well...

As a user, I can turn off battery notifications by untoggling the three options (full charge, low battery, and custom percentage notifs). And it would be more predictable if I didn't have to go back and forth between notification settings and battery settings. So I think it might be best to either move it to the top of the battery list items, or remove it altogether. I'm leaning towards the latter...

Honestly youre right it is pretty predictable already. I think it's safe to say we can scrap the master toggle for battery notifications 👍

[tituscmd]

Not sure if I am a fan of the warning message being in the footer tho. If you always run ANCS (which will be the standard in the future for iOS users), you would never see the information usually displayed there

[liamcharger]

My original concept was to include both messages, but I thought it simpler to just use a conditional. But I get what you're saying

I'd be okay with using a subtitle style on the toggle label, like so:

[tituscmd]

I'd be okay with using a subtitle style on the toggle label, like so:

Big, big fan of that! It makes the most sense as well imo, since it specifically shows what toggle is affected by it.

[liamcharger]

Pushed!

Once the toggle has been removed, I think we're good to merge :)

[tituscmd]

Pushed as well!