Skip to content

WIP Attempt to fix CI#439

Closed
dzenanz wants to merge 14 commits intoInsightSoftwareConsortium:mainfrom
dzenanz:fixCI
Closed

WIP Attempt to fix CI#439
dzenanz wants to merge 14 commits intoInsightSoftwareConsortium:mainfrom
dzenanz:fixCI

Conversation

@dzenanz
Copy link
Copy Markdown
Member

@dzenanz dzenanz commented Jan 31, 2025

This is a less aggressive rework of #437.

hjmjohnson and others added 14 commits January 27, 2025 17:19
@hjmjohnson
STYLE: Update to clang-format-19 style formatting
0b14ccd
@hjmjohnson
STYLE: Replace EdgeListPointerType with EdgeListType *
9c3236b 
Made it clearer that `QuadEdgeMeshBoundaryEdgesMeshFunction` just use a _raw_
pointer (not a smart pointer) to the edge list.
@hjmjohnson
STYLE: CoordRepType -> CoordinateType code readability
5faa768 
For the sake of code readability, a new 'CoordinateType' alias is added for
each nested 'CoordRepType' alias. The old 'CoordRepType' aliases will still be
available with ITK 6.0, but it is recommended to use 'CoordinateType' instead.
The 'CoordRepType' aliases will be removed when 'ITK_FUTURE_LEGACY_REMOVE' is
enabled. Similarly, 'InputCoordinateType', 'OutputCoordinateType', and
'ImagePointCoordinateType' replace 'InputCoordRepType', 'OutputCoordRepType',
and 'ImagePointCoordRepType', respectively.
@hjmjohnson
COMP: Remove unused variable warning.
f1f1318
@hjmjohnson
ENH: Update actions to latest tags
f2e9abc
@dzenanz
ENH: Use ITK master branch for linter
fff9e7e
@dzenanz
STYLE: Do not specify the latest version of setup-python
8b698aa
@dzenanz
ENH: Do not run duplicate GitHub actions in pull requests
df98e25
@dzenanz
COMP: Fix configure warning: install() DESTINATION paths are normalized
2593770 
The warning message was:

CMake Warning (dev) at src/IO/ImageBase/WriteAnImage/CMakeLists.txt:16 (install):
  Policy CMP0177 is not set: install() DESTINATION paths are normalized.  Run
  "cmake --help-policy CMP0177" for policy details.  Use the cmake_policy
  command to set the policy and suppress this warning.
This warning is for project developers.  Use -Wno-dev to suppress it.
@dzenanz
COMP: Simplify CMake code by removing superfluous policy specification
67b71dc
@dzenanz
STYLE: git:// protocol is being phased out, remove it as an option
f5ec02c
@dzenanz
ENH: Use newest ITK Python package in CI
06b02b3
@hjmjohnson @dzenanz
ENH: Update minimum cmake versions allowed.
87fe6be
@hjmjohnson @dzenanz
COMP: Update to ITK v5.4 and some related package versions
52174a4
@dzenanz
Copy link
Copy Markdown
Member Author

dzenanz commented Jan 31, 2025

Test failures from e.g. build-test-python-superbuild (macos-15):

The following tests FAILED:
	149 - DeformAVolumeWithAThinPlateSplineTestBaselineComparisonPython (Failed)
	229 - ComputeFFTInOneDimensionModulusBaselineComparisonPython (Failed)
	230 - ComputeFFTInOneDimensionPhaseBaselineComparisonPython (Failed)
	231 - ComputeInverseFFTOfImageTestBaselineComparisonPython (Failed)
	232 - ComputeFFTInOneDimensionTestPython (Failed)
	286 - ResampleAnImageTestBaselineComparisonPython (Failed)
	320 - ConvertRGBImageToGrayscaleImageTestBaselineComparisonPython (Failed)

and from CDash:

Test: ComputeFFTInOneDimensionModulusBaselineComparisonPython (Failed)
Build: InsightSoftwareConsortium/ITKSphinxExamples-macos-15--refs/pull/439/merge (GitHubActions) on 2025-01-31 19:26:54
Repository revision: bdd24a7cc1b7a1d841c5c3e435dcb5b0367e9875
Test Details: Completed (Failed)

Command line: /Users/runner/work/bld/ITKEx-build/bin/ImageCompareCommand "--test-image" "/Users/runner/work/bld/ITKEx-build/src/Filtering/FFT/ComputeFFTInOneDimension/MouseLiver1DFFTModulusOutputPython.mha.sha512" "--baseline-image" "/Users/runner/work/bld/ITKEx-build/src/Filtering/FFT/ComputeFFTInOneDimension/MouseLiver1DFFTModulusOutputBaseline.mha.sha512"

Test output

Exception detected while reading /Users/runner/work/bld/ITKEx-build/src/Filtering/FFT/ComputeFFTInOneDimension/MouseLiver1DFFTModulusOutputBaseline.mha.sha512 : 
itk::ImageFileReaderException (0x600003ca0800)
Location: "unknown" 
File: /Users/runner/work/bld/ITK/Modules/IO/ImageBase/include/itkImageFileReader.hxx
Line: 135
Description:  Could not create IO object for reading file /Users/runner/work/bld/ITKEx-build/src/Filtering/FFT/ComputeFFTInOneDimension/MouseLiver1DFFTModulusOutputBaseline.mha.sha512
The file doesn't exist. 
Filename = /Users/runner/work/bld/ITKEx-build/src/Filtering/FFT/ComputeFFTInOneDimension/MouseLiver1DFFTModulusOutputBaseline.mha.sha512


Exception detected while reading /Users/runner/work/bld/ITKEx-build/src/Filtering/FFT/ComputeFFTInOneDimension/MouseLiver1DFFTModulusOutputBaseline.mha.sha512 : 
itk::ImageFileReaderException (0x600003ca0800)
Location: "unknown" 
File: /Users/runner/work/bld/ITK/Modules/IO/ImageBase/include/itkImageFileReader.hxx
Line: 135
Description:  Could not create IO object for reading file /Users/runner/work/bld/ITKEx-build/src/Filtering/FFT/ComputeFFTInOneDimension/MouseLiver1DFFTModulusOutputBaseline.mha.sha512
The file doesn't exist. 
Filename = /Users/runner/work/bld/ITKEx-build/src/Filtering/FFT/ComputeFFTInOneDimension/MouseLiver1DFFTModulusOutputBaseline.mha.sha512


1000

@dzenanz dzenanz requested a review from hjmjohnson January 31, 2025 20:12
@hjmjohnson
Copy link
Copy Markdown
Member

hjmjohnson commented Apr 17, 2026

Closing this WIP CI fix PR. The diff shows no net changes relative to the current main branch, and CI has since been addressed through #447 (macOS runner pin upgrades) and #448 (lint workflow fix for ITKClangFormatLinterAction branch rename). The remaining pre-existing CI failures (build-test-cxx, build-test-documentation, build-test-python-superbuild) are being tracked for separate targeted fixes.

Thank you @dzenanz for the CI investigation.

@hjmjohnson hjmjohnson closed this Apr 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hjmjohnson hjmjohnson Awaiting requested review from hjmjohnson

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dzenanz @hjmjohnson