STYLE: Remove ITK version guards from Python examples - #484
Merged
hjmjohnson merged 1 commit intoSep 15, 2026
Merged
hjmjohnson merged 1 commit into
hjmjohnson merged 1 commit into
Conversation
dzenanz
approved these changes
Sep 14, 2026
The examples require ITK 6, so checks for ITK 4.7 through 5.2 can never fail. Drop them, along with the sys import they alone used.
hjmjohnson
force-pushed
the
style-remove-itk-version-guards
branch
from
September 15, 2026 15:51
efda8c3 to
979aa24
Compare
hjmjohnson
marked this pull request as ready for review
September 15, 2026 16:09
hjmjohnson
merged commit Sep 15, 2026
a97af16
into
InsightSoftwareConsortium:main
12 of 14 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the ITK version guards from ten Python examples. Examples require ITK 6,
so checks for ITK 4.7 through 5.2 can never fail.
What changes
Each example began with a check like:
The guard is removed, and so is
import sys, which in every one of these fileswas used only by the guard, along with the blank line each guard left behind.
10 files, 50 lines deleted, nothing added.
Verification
Against ITK
mainwith Python wrapping, all ten edited scripts import and run.Five of the examples have Python tests that run in the full build, and all pass:
AddOffsetToIndex,StreamAPipeline,CreateACustomColormap,SegmentBloodVessels, andSegmentBloodVesselsWithMultiScaleHessianBasedMeasure.The other five are not exercised by ctest, for reasons unrelated to this change:
ConvertAnitkImageTovtkImageData,ConvertAnRGBitkImageTovtkImageDataApplyGradientRecursiveGaussian,ApplyGradientRecursiveGaussianWithVectorInputImageGradientis inFiltering_MODULES_IGNORED("TODO: Fix ImageGradient examples and re-enable")Perform2DTranslationRegistrationWithMeanSquaresITKV4_COMPATIBILITYpre-commit run --all-filespasses.