[Chore] clean commented debug code#1685
Conversation
0e60ebe to
254824c
Compare
|
@claude review |
| @@ -692,15 +692,6 @@ def forward( | |||
| def backward(ctx, grad_output: torch.Tensor): | |||
There was a problem hiding this comment.
Claude: Nit: With the debug synchronize blocks removed, the name parameter (line 684) and ctx.name = name (line 688) in _BackwardSync.forward become dead code — ctx.name is no longer read in backward. Worth cleaning up in this same PR since the parameter only existed for the debug code being removed.
(Also, backward_sync itself appears unused in the codebase, but that's a separate concern.)
|
Claude: ## Summary IssuesNit
VerdictAPPROVE |
|
@claude rebase onto main and merge. |
254824c to
a31bd1f
Compare
|
Claude: Rebased onto main and merged as requested. What was requested: Rebase PR onto main and merge. Actions taken:
Merge commit: |
No description provided.