chore: sort & add contributor#379
Closed
github-actions[bot] wants to merge 1 commit into
Closed
Conversation
Owner
|
Closing — product of the broken all-contributors bot. This PR strips @JesperDramsch's contributions from 17 types down to just |
This was referenced Jun 27, 2026
JesperDramsch
added a commit
that referenced
this pull request
Jun 27, 2026
The pr-sort workflow ran an unconditional `all-contributors add <user> conference` before the jq guard meant to prevent re-adding an existing contribution type. all-contributors-cli replaces a contributor's entire contributions array when re-adding a type they already have, so the unconditional call collapsed contributors (e.g. JesperDramsch: 17 types -> ["conference"]) on every run. The guard then read the already-stripped file, found "conference" present, and skipped the second add — silently defeating the fix. Remove the unconditional add so the jq guard is the only add path: skip when the contributor already has "conference", add only for genuinely new contributors. Fixes the corruption behind the closed PRs #371 and #379.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated workflow update