Skip to content

Speed up CSC substitution decompression for stars #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amontoison merged 6 commits into from
Oct 27, 2026
Merged

Speed up CSC substitution decompression for stars #354

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
016e0b0
Speed up CSC substitution decompression for one-edge trees
blegat Oct 19, 2026
7fe7c24
No substitution for stars
blegat Oct 22, 2026
d2e0a0e
else instead of continue
blegat Oct 22, 2026
0933127
Speed up stars in bicoloring as well
blegat Oct 22, 2026
715b6f2
Skip substitution for stars in dense decompress! of TreeSetColoringRe…
blegat Oct 26, 2026
9bb0e21
Fix typos and clarify vertex offset comment in TreeSet
blegat Oct 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/coloring.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -491,7 +491,7 @@ struct TreeSet{T}
(BFS) traversal order of the `k`th tree starting from a depth-minimizing root.
"""
reverse_bfs_orders::Vector{Tuple{T,T}}
"For a tree index `1 <= k <= nt`, `is_star[k]` indicates whether the `k`th three is a star."
"For a tree index `1 <= k <= nt`, `is_star[k]` indicates whether the `k`th tree is a star."
is_star::Vector{Bool}
"""
`tree_edge_indices[1]` is one and `tree_edge_indices[k+1] - tree_edge_indices[k]` is the number of edges in the `k`th tree.
Expand Down Expand Up @@ -656,8 +656,9 @@ function TreeSet(
queue_end = 0

# Positions of the first and last vertices in the current tree
# Note: tree_edge_indices contains the positions of the first and last edges,
# so we add to add an offset k-1 between edge indices and vertex indices
# Note: tree_edge_indices contains the positions of the first and last edges.
# Each tree has one more vertex than edges, so the k-1 previous trees shift
# the vertex positions by k-1 with respect to the edge positions.
first_vertex = tree_edge_indices[k] + (k - 1)
last_vertex = tree_edge_indices[k + 1] + (k - 1)

Expand Down
Loading
Loading