Fix compilecache being called with too-permissive extension rights#4652
Open
topolarity wants to merge 1 commit intorelease-1.10from
Open
Fix compilecache being called with too-permissive extension rights#4652topolarity wants to merge 1 commit intorelease-1.10from
compilecache being called with too-permissive extension rights#4652topolarity wants to merge 1 commit intorelease-1.10from
Conversation
It is required to pass `loadable_exts` to the sub-process now that we allow ext → ext edges (and ban circularities) on 1.10.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes our handling of
ext → extdependencies on 1.10, resolving EnzymeAD/Reactant.jl#2764.Why did our 1.10 tests not catch this?
Unfortunately I made two serious mistakes in the backport of #4619 (and related Julia PR's):
compilecacheon the Pkg.jl sideBase.disable_parallel_precompile = true / falsemechanism does not exist on 1.10. Julia does not complain about creating the new global in Base, so the missing parallel coverage is silent. The tests landed match1.11+, but they end up only testing the (serial)Base._requirepathway.