Skip to content

Search the release branch first for a commit to tag - #607

Open
CiaranOMara wants to merge 1 commit into
JuliaRegistries:masterfrom
CiaranOMara:prefer-release-branch
Open

CiaranOMara wants to merge 1 commit into
JuliaRegistries:masterfrom
CiaranOMara:prefer-release-branch

Conversation

@CiaranOMara

Copy link
Copy Markdown

The README says that the branch set by the branch input is the first one searched for a commit to tag, but the tree→commit cache read git log --all alone, keeping the most recent commit for each tree. Where several commits share a registered tree, such as a release's merge commit on the release branch and a later merge of it into a development branch under gitflow, TagBot tagged the latter, which the registry didn't register and which isn't on the release branch.

With branch set, the cache now reads that branch's history first, then the full history, so the commit on the release branch wins. The subdirectory cache, derived from the full cache, follows. Without branch, the cache is built as before.

The README says that the branch set by the `branch` input is the first one searched for a commit to tag, but the tree→commit cache read `git log --all` alone, keeping the most recent commit for each tree.
Where several commits share a registered tree, such as a release's merge commit on the release branch and a later merge of it into a development branch under gitflow, TagBot tagged the latter, which the registry didn't register and which isn't on the release branch.

With `branch` set, the cache now reads that branch's history first, then the full history, so the commit on the release branch wins.
The subdirectory cache, derived from the full cache, follows.
Without `branch`, the cache is built as before.
@CiaranOMara
CiaranOMara force-pushed the prefer-release-branch branch from 00fa6f9 to db27c47 Compare October 27, 2026 06:07

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant