build: migrate dependency management from requirements.txt to uv#3
Open
ganow wants to merge 5 commits into
Open
build: migrate dependency management from requirements.txt to uv#3ganow wants to merge 5 commits into
ganow wants to merge 5 commits into
Conversation
…encoder_fastl2lir.py in README.md
KenyaOtsuka
reviewed
Jun 4, 2026
KenyaOtsuka
left a comment
There was a problem hiding this comment.
I left one inline comment about a typo.
Also, since jupyter and pycortex are included as optional dependencies under the visualization extra, I think it would be helpful to mention in the README that users need to run uv sync --extra visualization before running evaluation.ipynb.
Other than that, the changes look good to me.
| [project] | ||
| name = "feature-encoding" | ||
| version = "0.1.0" | ||
| description = "DNN feature encoding analysis to predict fMRI responses (Nonaki et al., 2021)" |
Author
|
@KenyaOtsuka Thank you for reviewing this PR! All of your comments make sense. I'll apply them later |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Migrate dependency management from
requirements.txtto uv (pyproject.toml+uv.lock). Along the way, this also fixes a few issues found inREADME.md,data/files.json, andevaluation.ipynb.Changes
Migration to uv (main)
Replace
requirements.txtwithpyproject.toml+uv.lock, and update the README setup instructions to useuv sync. Dependencies are carried over as-is fromrequirements.txt, withjupyter/pycortexadded under an optionalvisualizationgroup.Incidental fixes
Clean up minor issues found while running the examples (outdated script name in the README, a JSON syntax error, unused imports in the notebook). As part of this, I restored the
pycortexdownload entry indata/files.jsonby recovering it from the commit history; I'm not certain about its details yet and have asked the previous maintainer in #2, but restored it for now so the Pycortex visualization works.Verification
Verified end-to-end by running the Examples section of the README:
🤖 Generated with Claude Code