tests: do not fail encode tests the decoder cannot validate - #232
Open
crmurillo wants to merge 1 commit into
Open
tests: do not fail encode tests the decoder cannot validate#232crmurillo wants to merge 1 commit into
crmurillo wants to merge 1 commit into
Conversation
Decoder validation is executed after every successful encode and any non-zero decoder exit marked the encode test as failed. That mixes two different scenarios: an encoded file that is actually broken, and a decoder that has no support for the encoded configuration. Print a warning in case the decoder does not have the capabilities to validate the encoded file and mark the encode test as successful (decoder validation runs only if encoding was successful). The decoder reports this before decoding anything, so there is no information about the validity of the encoded file.
crmurillo
force-pushed
the
fix_decoder_validation
branch
from
August 20, 2026 07:47
7b4de67 to
5affc6d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Decoder validation is executed after every successful encode and any non-zero decoder exit marked the encode test as failed. That mixes two different scenarios: an encoded file that is actually broken, and a decoder that has no support for the encoded configuration.
Print a warning in case the decoder does not have the capabilities to validate the encoded file and mark the encode test as successful. The decoder reports this before decoding anything, so there is no information about the validity of the encoded file.
See #231 for details and how to reproduce.
Type of change
bug fix
Issue (optional)
Fixes part of #231 .
Tests
NVIDIA GeForce RTX 4060 Ti / NVIDIA 595.44.00 / Ubuntu 24.04.4 LTS
Total Tests: 83
Passed: 72
Crashed: 0
Failed: 0
Not Supported: 10
Skipped: 1 (in skip list)
Success Rate: 100.0%