Make right-click recenter opt-in - #1836
Conversation
Right-click recentering the annotator has been on unconditionally since #1747, which fights right-click's primary role as the edit action. Gate it on a User Settings toggle, defaulting off.
|
This is an issue indicated by that PR, but it should probablly default to the track locking indicator and not some new setting. The current lock icon is used to center when selecting tracks and it should probably use that. |
Reuse the existing "center camera on selected track" control instead of a second setting for the same idea. Still off by default.
|
Good call — done in 14cb2b8. Dropped the new setting entirely and gated the recenter on One thing worth a sanity check from you, since it's a behavior change rather than just a relocation: the two are now coupled in both directions. Enabling the lock to get track-following also turns right-click recenter on, and anyone who wants right-click-to-center has to accept the camera jumping on every track selection. That seems like the intent — they're both "auto-centering" — but if you'd rather they stay independent, the alternative is a second entry in the lock icon's popover (next to Transition / Multiply Bounds) rather than a User Settings switch. Say the word and I'll move it there. Tests cover the three states: no recenter with the lock off, recenter with it on, left-click ignored either way. Worth noting the aligned-view spec's viewer mock had no |
BryonLewis
left a comment
There was a problem hiding this comment.
one small change to suppress multiple component warnings in the testing for useLayerManagerAlignedView
Right-click in the annotator recenters the view on the clicked point. That has
been on unconditionally since #1747 (
AlignedImageLayer), including in singlecamera, non-aligned datasets. It fights right-click's primary role as the
context/edit action: right-clicking a detection to edit it also jumps the view.
Gate it on a User Settings toggle, defaulting off. The behavior is
unchanged for anyone who turns it on.
navigationSettings.rightClickRecenterinclientSettings(persisted, defaultfalse)useLayerManagerAlignedViewANDs it with the existing "not while editing geometry" guardTests cover all three states: no recenter by default, recenter when enabled,
and left-click ignored when enabled.
🤖 Generated with Claude Code