Repository navigation
fix: sanitize keys with optional PEM fields - #2327
Open
pcbeingused333 wants to merge 2 commits into
Open
pcbeingused333 wants to merge 2 commits into
pcbeingused333 wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sanitizing a key with only a public or private PEM field panics because
handleKeydereferences both optional input fields when recording their sanitized values. Kong accepts either field on its own.Only populate sanitized PEM fields that are present in the input, and guard each map insertion with a nil check. The existing replacement key pair generation remains unchanged. Add regression coverage through
NewSanitizerfor public-only, private-only, and complete PEM inputs, checking that supplied values are replaced and recorded consistently and absent fields stay nil.Testing: on current main (387ed97), the regression fails with nil-pointer panics in both single-field cases (2 failures, 1 pass). With this fix all 3 cases pass. The entire
sanitizepackage also passes. The targeted command isGOTOOLCHAIN=local go test ./sanitize -run Test_SanitizeKeyOptionalPEM -count=1. Formatting andgit diff --checkpass.This change was prepared with AI assistance (OpenAI Codex).