Repository navigation
Conversation
- Find a control's data rows via the indexed SinglePointControlId instead of joining on description
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
This PR speeds up the Levey-Jennings report for single point controls, which takes 2–5 minutes to load on a client server with many Luminex runs. Query profiling on a client server showed nearly all of the time in the report grid's Average Fi Bkgd column. It found a control's data rows through a join on description, so the per-well exclusion check ran on every data row for the analyte in the run before most were filtered out.
Changes
Tasks