Sample color display - grid column renderer, sample detail header, storage box view, etc. - #2056
Merged
Conversation
…E_COLOR_REQUIRED_COLUMNS in requiredColumns
…when no colors defined in project
…n header" for sample type with sample color breakdown
XingY
approved these changes
Aug 17, 2026
|
|
||
| export function setActiveProjectColors(moduleContext: ModuleContext, hasActiveProjectColors: boolean): ModuleContext { | ||
| // side-effect set global moduleContext | ||
| if (LABKEY?.moduleContext?.samplemanagement) { |
Contributor
There was a problem hiding this comment.
Perhaps something for future, but would be good to indicate to other active sessions that a color is no longer active to avoid additional usage.
Contributor
Author
There was a problem hiding this comment.
Yeah, I like that idea but that seems like a future TODO once we see how much the sample color feature (and archived colors in particular) gets used.
| columns: string[], | ||
| colFieldKeyMap?: Record<string, string> | ||
| colFieldKeyMap?: Record<string, string>, | ||
| displayValueKeys?: string[] |
Contributor
There was a problem hiding this comment.
I see this is used by eln/Tooltip. Wonder why similar treatment is not needed for sample status which also contains color display?
Contributor
Author
There was a problem hiding this comment.
Good call. Turns out I don't need to do this displayValueKeys behavior if we just query for the ExpMaterialColor/Label directly, instead of relying on displayValue of ExpMaterialColor, in the ToolTipLoader.ts loadSampleData
cnathe
added a commit
to LabKey/platform
that referenced
this pull request
Aug 18, 2026
…orage box view, etc. (#7932) ## Rationale Server-side foundation for the sample color work: expose the set of active project colors through `ExperimentService` so clients can determine whether a project has colors defined and gate color display accordingly, and remove the experimental feature flag now that the feature is complete. ## Related Pull Requests - LabKey/labkey-ui-components#2056 - LabKey/labkey-ui-premium#1014 - LabKey/limsModules#2402 - #7932 ## Changes - Added `ExperimentService.getActiveProjectColors()`, which backs the `hasActiveProjectColors` module context flag consumed by the client apps. - Renamed `ExperimentService.getDataColorLabel()` to `getDataColor()`. - Sample listing grids include `ExpMaterialColor` and use `SAMPLE_COLOR_REQUIRED_COLUMNS` for `requiredColumns`. - Removed the experimental feature flag.
cnathe
added a commit
to LabKey/testAutomation
that referenced
this pull request
Aug 18, 2026
…orage box view, etc. (#3156) ## Rationale See related PR for rationale. This PR adds test helpers for getting various sample color related dom elements. ## Related Pull Requests - LabKey/labkey-ui-components#2056 - LabKey/labkey-ui-premium#1014 - LabKey/limsModules#2402 - LabKey/platform#7932 ## Changes - Selenium test helpers for sample color test cases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Surface the sample color assigned via project-level sample colors throughout the sample UI — grid columns, detail views, lineage details, editable grids, and storage capacity breakdowns — and only include the color column where the project actually has active colors defined. Also removes the experimental feature flag now that the feature is complete.
Related Pull Requests
Changes
ExpMaterialColorand useSAMPLE_COLOR_REQUIRED_COLUMNSforrequiredColumns; addedQueryInfo.showSampleColorColand exportedSAMPLE_COLOR_COLOR_COLUMN_NAME.Apphelpers to readhasActiveProjectColorsfrommoduleContext, used to gate color display:getOmittedSampleTypeColumnsaddsSAMPLE_COLOR_REQUIRED_COLUMNSwhen no colors are defined in the project, and sample type system fields includeExpMaterialColoronly when colors are active.SampleColorRenderer: addedcls,showLabel, anduseSmallprops plus styling updates;SampleColorInputoption renderer now includesColorIcon.HorizontalBarSectionandItemsLegendhandle a section header for the sample type with sample color breakdown.QueryModel.flattenValuesFromRownow carriesdisplayValue.